Skip to content

Commit 351c75c

Browse files
committed
private name tests strict+es6
Update private name tests to use 'strict' type checking and to target es6 instead of default. Makes the js output easier to read and tests more surface area with other checker features. Signed-off-by: Max Heiber <[email protected]>
1 parent a4bc65b commit 351c75c

File tree

89 files changed

+627
-354
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

89 files changed

+627
-354
lines changed

tests/baselines/reference/privateNameAndIndexSignature.errors.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts(4,14): error TS2339: Property '#f' does not exist on type 'A'.
1+
tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts(6,14): error TS2339: Property '#f' does not exist on type 'A'.
22

33

44
==== tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts (1 errors) ====
5+
// @target es6
6+
57
class A {
68
[k: string]: any;
79
constructor(message: string) {

tests/baselines/reference/privateNameAndIndexSignature.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
//// [privateNameAndIndexSignature.ts]
2+
// @target es6
3+
24
class A {
35
[k: string]: any;
46
constructor(message: string) {
@@ -8,6 +10,8 @@ class A {
810

911

1012
//// [privateNameAndIndexSignature.js]
13+
"use strict";
14+
// @target es6
1115
var A = /** @class */ (function () {
1216
function A(message) {
1317
this.#f = 3; // Error Property '#f' does not exist on type 'A'.

tests/baselines/reference/privateNameAndIndexSignature.symbols

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
=== tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts ===
2+
// @target es6
3+
24
class A {
35
>A : Symbol(A, Decl(privateNameAndIndexSignature.ts, 0, 0))
46

57
[k: string]: any;
6-
>k : Symbol(k, Decl(privateNameAndIndexSignature.ts, 1, 5))
8+
>k : Symbol(k, Decl(privateNameAndIndexSignature.ts, 3, 5))
79

810
constructor(message: string) {
9-
>message : Symbol(message, Decl(privateNameAndIndexSignature.ts, 2, 16))
11+
>message : Symbol(message, Decl(privateNameAndIndexSignature.ts, 4, 16))
1012

1113
this.#f = 3 // Error Property '#f' does not exist on type 'A'.
1214
>this : Symbol(A, Decl(privateNameAndIndexSignature.ts, 0, 0))

tests/baselines/reference/privateNameAndIndexSignature.types

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
=== tests/cases/conformance/classes/members/privateNames/privateNameAndIndexSignature.ts ===
2+
// @target es6
3+
24
class A {
35
>A : A
46

tests/baselines/reference/privateNameConstructorReserved.errors.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts(2,5): error TS18006: '#constructor' is a reserved word.
1+
tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts(4,5): error TS18006: '#constructor' is a reserved word.
22

33

44
==== tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts (1 errors) ====
5+
// @target es6
6+
57
class A {
68
#constructor() {} // Error: `#constructor` is a reserved word.
79
~~~~~~~~~~~~

tests/baselines/reference/privateNameConstructorReserved.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
//// [privateNameConstructorReserved.ts]
2+
// @target es6
3+
24
class A {
35
#constructor() {} // Error: `#constructor` is a reserved word.
46
}
57

68

79
//// [privateNameConstructorReserved.js]
10+
// @target es6
811
var A = /** @class */ (function () {
912
function A() {
1013
}
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
=== tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts ===
2+
// @target es6
3+
24
class A {
35
>A : Symbol(A, Decl(privateNameConstructorReserved.ts, 0, 0))
46

57
#constructor() {} // Error: `#constructor` is a reserved word.
6-
>#constructor : Symbol(A[#constructor], Decl(privateNameConstructorReserved.ts, 0, 9))
8+
>#constructor : Symbol(A.#constructor, Decl(privateNameConstructorReserved.ts, 2, 9))
79
}
810

tests/baselines/reference/privateNameConstructorReserved.types

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
=== tests/cases/conformance/classes/members/privateNames/privateNameConstructorReserved.ts ===
2+
// @target es6
3+
24
class A {
35
>A : A
46

tests/baselines/reference/privateNameDuplicateField.errors.txt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
tests/cases/conformance/classes/members/privateNames/privateNameDuplicateField.ts(3,5): error TS2300: Duplicate identifier '#foo'.
1+
tests/cases/conformance/classes/members/privateNames/privateNameDuplicateField.ts(5,5): error TS2300: Duplicate identifier '#foo'.
22

33

44
==== tests/cases/conformance/classes/members/privateNames/privateNameDuplicateField.ts (1 errors) ====
5+
// @target es6
6+
57
class A {
6-
#foo;
7-
#foo;
8+
#foo = "foo";
9+
#foo = "foo";
810
~~~~
911
!!! error TS2300: Duplicate identifier '#foo'.
1012
}
Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,21 @@
11
//// [privateNameDuplicateField.ts]
2+
// @target es6
3+
24
class A {
3-
#foo;
4-
#foo;
5+
#foo = "foo";
6+
#foo = "foo";
57
}
68

79

810
//// [privateNameDuplicateField.js]
11+
// @target es6
12+
var _foo, _foo_1;
13+
"use strict";
914
var A = /** @class */ (function () {
1015
function A() {
16+
_foo_1.set(this, "foo");
17+
_foo_1.set(this, "foo");
1118
}
1219
return A;
1320
}());
21+
_foo = new WeakMap(), _foo_1 = new WeakMap();

0 commit comments

Comments
 (0)