error message for private names in obj literals

Author: mheiber

src/compiler/binder.ts

@@ -273,7 +273,12 @@ namespace ts {
                 }
                 if (isPrivateName(name)) {
                     // containingClass exists because private names only allowed inside classes
-                    const containingClassSymbol = getContainingClass(name.parent)!.symbol;
+                    const containingClass = getContainingClass(name.parent);
+                    if (!containingClass) {
+                        // we're in a case where there's a private name outside a class (invalid)
+                        return undefined;
+                    }
+                    const containingClassSymbol = containingClass.symbol;
                     return getPropertyNameForPrivateNameDescription(containingClassSymbol, name.escapedText);
                 }
                 return isPropertyNameLiteral(name) ? getEscapedTextOfIdentifierOrLiteral(name) : undefined;

src/compiler/checker.ts

@@ -29681,6 +29681,10 @@ namespace ts {
                     return grammarErrorOnNode(prop.equalsToken!, Diagnostics.can_only_be_used_in_an_object_literal_property_inside_a_destructuring_assignment);
                 }
 
+                if (name.kind === SyntaxKind.PrivateName) {
+                    return grammarErrorOnNode(name, Diagnostics.Private_names_are_not_allowed_outside_class_bodies);
+                }
+
                 // Modifiers are never allowed on properties except for 'async' on a method declaration
                 if (prop.modifiers) {
                     for (const mod of prop.modifiers!) { // TODO: GH#19955

src/compiler/diagnosticMessages.json

@@ -4319,10 +4319,14 @@
         "category": "Error",
         "code": 18008
     },
-    "Property '{0}' is missing in type '{1}'. While type '{1}' has a private member with the same spelling, its declaration and accessibility are distinct": {
+    "Property '{0}' is missing in type '{1}'. While type '{1}' has a private member with the same spelling, its declaration and accessibility are distinct.": {
         "category": "Error",
         "code": 18009
     },
+    "Private names are not allowed outside class bodies.": {
+        "category": "Error",
+        "code": 18010
+    },
 
     "File is a CommonJS module; it may be converted to an ES6 module.": {
         "category": "Suggestion",

src/compiler/types.ts

@@ -822,7 +822,7 @@ namespace ts {
         expression: Expression;
     }
 
-    export interface PrivateName extends Declaration {
+    export interface PrivateName extends Expression, Declaration {
         kind: SyntaxKind.PrivateName;
         // escaping not strictly necessary
         // avoids gotchas in transforms and utils

tests/baselines/reference/privateNameInObjectLiteral-1.errors.txt

@@ -0,0 +1,10 @@
+tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-1.ts(2,5): error TS18010: Private names are not allowed outside class bodies.
+
+
+==== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-1.ts (1 errors) ====
+    const obj = {
+        #foo: 1
+        ~~~~
+!!! error TS18010: Private names are not allowed outside class bodies.
+    };
+    

tests/baselines/reference/privateNameInObjectLiteral-1.js

@@ -0,0 +1,10 @@
+//// [privateNameInObjectLiteral-1.ts]
+const obj = {
+    #foo: 1
+};
+
+
+//// [privateNameInObjectLiteral-1.js]
+var obj = {
+    #foo: 1
+};

tests/baselines/reference/privateNameInObjectLiteral-1.symbols

@@ -0,0 +1,9 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-1.ts ===
+const obj = {
+>obj : Symbol(obj, Decl(privateNameInObjectLiteral-1.ts, 0, 5))
+
+    #foo: 1
+>#foo : Symbol(#foo, Decl(privateNameInObjectLiteral-1.ts, 0, 13))
+
+};
+

tests/baselines/reference/privateNameInObjectLiteral-1.types

@@ -0,0 +1,11 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-1.ts ===
+const obj = {
+>obj : {}
+>{    #foo: 1} : {}
+
+    #foo: 1
+>#foo : number
+>1 : 1
+
+};
+

tests/baselines/reference/privateNameInObjectLiteral-2.errors.txt

@@ -0,0 +1,12 @@
+tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-2.ts(2,5): error TS18010: Private names are not allowed outside class bodies.
+
+
+==== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-2.ts (1 errors) ====
+    const obj = {
+        #foo() {
+        ~~~~
+!!! error TS18010: Private names are not allowed outside class bodies.
+    
+        }
+    };
+    

tests/baselines/reference/privateNameInObjectLiteral-2.js

@@ -0,0 +1,13 @@
+//// [privateNameInObjectLiteral-2.ts]
+const obj = {
+    #foo() {
+
+    }
+};
+
+
+//// [privateNameInObjectLiteral-2.js]
+var obj = {
+    #foo: function () {
+    }
+};

tests/baselines/reference/privateNameInObjectLiteral-2.symbols

@@ -0,0 +1,10 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-2.ts ===
+const obj = {
+>obj : Symbol(obj, Decl(privateNameInObjectLiteral-2.ts, 0, 5))
+
+    #foo() {
+>#foo : Symbol(#foo, Decl(privateNameInObjectLiteral-2.ts, 0, 13))
+
+    }
+};
+

tests/baselines/reference/privateNameInObjectLiteral-2.types

@@ -0,0 +1,11 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-2.ts ===
+const obj = {
+>obj : {}
+>{    #foo() {    }} : {}
+
+    #foo() {
+>#foo : () => void
+
+    }
+};
+

tests/baselines/reference/privateNameInObjectLiteral.errors.txt

@@ -0,0 +1,14 @@
+tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral.ts(2,5): error TS18010: Private names are not allowed outside class bodies.
+
+
+==== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral.ts (1 errors) ====
+    const obj = {
+        #foo: "#foo",
+        ~~~~
+!!! error TS18010: Private names are not allowed outside class bodies.
+        #bar: () => true,
+        #baz() {
+            return true;
+        }
+    };
+    

tests/baselines/reference/privateNameInObjectLiteral.js

@@ -0,0 +1,18 @@
+//// [privateNameInObjectLiteral.ts]
+const obj = {
+    #foo: "#foo",
+    #bar: () => true,
+    #baz() {
+        return true;
+    }
+};
+
+
+//// [privateNameInObjectLiteral.js]
+var obj = {
+    #foo: "#foo",
+    #bar: function () { return true; },
+    #baz: function () {
+        return true;
+    }
+};

tests/baselines/reference/privateNameInObjectLiteral.symbols

@@ -0,0 +1,17 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral.ts ===
+const obj = {
+>obj : Symbol(obj, Decl(privateNameInObjectLiteral.ts, 0, 5))
+
+    #foo: "#foo",
+>#foo : Symbol(#foo, Decl(privateNameInObjectLiteral.ts, 0, 13))
+
+    #bar: () => true,
+>#bar : Symbol(#bar, Decl(privateNameInObjectLiteral.ts, 1, 17))
+
+    #baz() {
+>#baz : Symbol(#baz, Decl(privateNameInObjectLiteral.ts, 2, 21))
+
+        return true;
+    }
+};
+

tests/baselines/reference/privateNameInObjectLiteral.types

@@ -0,0 +1,22 @@
+=== tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral.ts ===
+const obj = {
+>obj : {}
+>{    #foo: "#foo",    #bar: () => true,    #baz() {        return true;    }} : {}
+
+    #foo: "#foo",
+>#foo : string
+>"#foo" : "#foo"
+
+    #bar: () => true,
+>#bar : () => boolean
+>() => true : () => boolean
+>true : true
+
+    #baz() {
+>#baz : () => boolean
+
+        return true;
+>true : true
+    }
+};
+

tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-1.ts

@@ -0,0 +1,3 @@
+const obj = {
+    #foo: 1
+};

tests/cases/conformance/classes/members/privateNames/privateNameInObjectLiteral-2.ts

@@ -0,0 +1,5 @@
+const obj = {
+    #foo() {
+
+    }
+};