feat(NODE-4817)!: remove legacy logger (mongodb#3518)

Author: W-A-James

src/cmap/connection_pool.ts

@@ -22,7 +22,6 @@ import {
   MongoRuntimeError,
   MongoServerError
 } from '../error';
-import { Logger } from '../logger';
 import { CancellationToken, TypedEventEmitter } from '../mongo_types';
 import type { Server } from '../sdam/server';
 import { Callback, eachAsync, List, makeCounter } from '../utils';
@@ -52,8 +51,6 @@ import { ConnectionPoolMetrics } from './metrics';
 /** @internal */
 const kServer = Symbol('server');
 /** @internal */
-const kLogger = Symbol('logger');
-/** @internal */
 const kConnections = Symbol('connections');
 /** @internal */
 const kPending = Symbol('pending');
@@ -140,7 +137,6 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
   options: Readonly<ConnectionPoolOptions>;
   [kPoolState]: typeof PoolState[keyof typeof PoolState];
   [kServer]: Server;
-  [kLogger]: Logger;
   [kConnections]: List<Connection>;
   [kPending]: number;
   [kCheckedOut]: Set<Connection>;
@@ -239,7 +235,6 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
 
     this[kPoolState] = PoolState.paused;
     this[kServer] = server;
-    this[kLogger] = new Logger('ConnectionPool');
     this[kConnections] = new List();
     this[kPending] = 0;
     this[kCheckedOut] = new Set();
@@ -642,7 +637,6 @@ export class ConnectionPool extends TypedEventEmitter<ConnectionPoolEvents> {
 
     connect(connectOptions, (err, connection) => {
       if (err || !connection) {
-        this[kLogger].debug(`connection attempt failed with error [${JSON.stringify(err)}]`);
         this[kPending]--;
         this.emit(
           ConnectionPool.CONNECTION_CLOSED,

src/collection.ts

@@ -8,7 +8,6 @@ import { FindCursor } from './cursor/find_cursor';
 import { ListIndexesCursor } from './cursor/list_indexes_cursor';
 import type { Db } from './db';
 import { MongoInvalidArgumentError } from './error';
-import type { Logger, LoggerOptions } from './logger';
 import type { PkFactory } from './mongo_client';
 import type {
   Filter,
@@ -105,10 +104,7 @@ export interface ModifyResult<TSchema = Document> {
 }
 
 /** @public */
-export interface CollectionOptions
-  extends BSONSerializeOptions,
-    WriteConcernOptions,
-    LoggerOptions {
+export interface CollectionOptions extends BSONSerializeOptions, WriteConcernOptions {
   /** Specify a read concern for the collection. (only MongoDB 3.2 or higher supported) */
   readConcern?: ReadConcernLike;
   /** The preferred read preference (ReadPreference.PRIMARY, ReadPreference.PRIMARY_PREFERRED, ReadPreference.SECONDARY, ReadPreference.SECONDARY_PREFERRED, ReadPreference.NEAREST). */
@@ -1535,15 +1531,6 @@ export class Collection<TSchema extends Document = Document> {
     return new OrderedBulkOperation(this as TODO_NODE_3286, resolveOptions(this, options));
   }
 
-  /** Get the db scoped logger */
-  getLogger(): Logger {
-    return this.s.db.s.logger;
-  }
-
-  get logger(): Logger {
-    return this.s.db.s.logger;
-  }
-
   /**
    * An estimated count of matching documents in the db to a filter.
    *

src/connection_string.ts

@@ -14,7 +14,6 @@ import {
   MongoMissingCredentialsError,
   MongoParseError
 } from './error';
-import { Logger as LegacyLogger, LoggerLevel as LegacyLoggerLevel } from './logger';
 import {
   DriverInfo,
   MongoClient,
@@ -870,24 +869,6 @@ export const OPTIONS = {
     default: 15,
     type: 'uint'
   },
-  logger: {
-    default: new LegacyLogger('MongoClient'),
-    transform({ values: [value] }) {
-      if (value instanceof LegacyLogger) {
-        return value;
-      }
-      emitWarning('Alternative loggers might not be supported');
-      // TODO: make Logger an interface that others can implement, make usage consistent in driver
-      // DRIVERS-1204
-      return;
-    }
-  },
-  loggerLevel: {
-    target: 'logger',
-    transform({ values: [value] }) {
-      return new LegacyLogger('MongoClient', { loggerLevel: value as LegacyLoggerLevel });
-    }
-  },
   maxConnecting: {
     default: 2,
     transform({ name, values: [value] }): number {

src/db.ts

@@ -6,7 +6,6 @@ import * as CONSTANTS from './constants';
 import { AggregationCursor } from './cursor/aggregation_cursor';
 import { ListCollectionsCursor } from './cursor/list_collections_cursor';
 import { MongoAPIError, MongoInvalidArgumentError } from './error';
-import { Logger, LoggerOptions } from './logger';
 import type { MongoClient, PkFactory } from './mongo_client';
 import type { TODO_NODE_3286 } from './mongo_types';
 import { AddUserOperation, AddUserOptions } from './operations/add_user';
@@ -64,8 +63,6 @@ const DB_OPTIONS_ALLOW_LIST = [
   'readConcern',
   'retryMiliSeconds',
   'numberOfRetries',
-  'loggerLevel',
-  'logger',
   'promoteBuffers',
   'promoteLongs',
   'bsonRegExp',
@@ -79,7 +76,6 @@ const DB_OPTIONS_ALLOW_LIST = [
 export interface DbPrivate {
   client: MongoClient;
   options?: DbOptions;
-  logger: Logger;
   readPreference?: ReadPreference;
   pkFactory: PkFactory;
   readConcern?: ReadConcern;
@@ -89,7 +85,7 @@ export interface DbPrivate {
 }
 
 /** @public */
-export interface DbOptions extends BSONSerializeOptions, WriteConcernOptions, LoggerOptions {
+export interface DbOptions extends BSONSerializeOptions, WriteConcernOptions {
   /** If the database authentication is dependent on another databaseName. */
   authSource?: string;
   /** Force server to assign _id values instead of driver. */
@@ -159,8 +155,6 @@ export class Db {
       client,
       // Options
       options,
-      // Logger instance
-      logger: new Logger('Db', options),
       // Unpack read preference
       readPreference: ReadPreference.fromOptions(options),
       // Merge bson options
@@ -756,15 +750,6 @@ export class Db {
 
     return new ChangeStream<TSchema, TChange>(this, pipeline, resolveOptions(this, options));
   }
-
-  /** Return the db logger */
-  getLogger(): Logger {
-    return this.s.logger;
-  }
-
-  get logger(): Logger {
-    return this.s.logger;
-  }
 }
 
 // TODO(NODE-3484): Refactor into MongoDBNamespace

src/gridfs/index.ts

@@ -3,7 +3,6 @@ import type { Collection } from '../collection';
 import type { FindCursor } from '../cursor/find_cursor';
 import type { Db } from '../db';
 import { MongoRuntimeError } from '../error';
-import type { Logger } from '../logger';
 import { Filter, TypedEventEmitter } from '../mongo_types';
 import type { ReadPreference } from '../read_preference';
 import type { Sort } from '../sort';
@@ -225,9 +224,4 @@ export class GridFSBucket extends TypedEventEmitter<GridFSBucketEvents> {
       await this.s._chunksCollection.drop();
     }, callback);
   }
-
-  /** Get the Db scoped logger. */
-  getLogger(): Logger {
-    return this.s.db.s.logger;
-  }
 }

src/index.ts

@@ -12,7 +12,6 @@ import { Db } from './db';
 import { GridFSBucket } from './gridfs';
 import { GridFSBucketReadStream } from './gridfs/download';
 import { GridFSBucketWriteStream } from './gridfs/upload';
-import { Logger } from './logger';
 import { MongoClient } from './mongo_client';
 import { CancellationToken } from './mongo_types';
 import { ClientSession } from './sessions';
@@ -86,7 +85,6 @@ export {
   GridFSBucketWriteStream,
   ListCollectionsCursor,
   ListIndexesCursor,
-  Logger,
   MongoClient,
   OrderedBulkOperation,
   UnorderedBulkOperation
@@ -101,7 +99,6 @@ export { CURSOR_FLAGS } from './cursor/abstract_cursor';
 export { AutoEncryptionLoggerLevel } from './deps';
 export { MongoErrorLabel } from './error';
 export { ExplainVerbosity } from './explain';
-export { LoggerLevel } from './logger';
 export { ServerApiVersion } from './mongo_client';
 export { ReturnDocument } from './operations/find_and_modify';
 export { ProfilingLevel } from './operations/set_profiling_level';
@@ -269,7 +266,6 @@ export type {
 } from './gridfs/download';
 export type { GridFSBucketEvents, GridFSBucketOptions, GridFSBucketPrivate } from './gridfs/index';
 export type { GridFSBucketWriteStreamOptions, GridFSChunk } from './gridfs/upload';
-export type { LoggerFunction, LoggerOptions } from './logger';
 export type {
   Auth,
   DriverInfo,