MempoolTxTableModel::sort:initial impl

Author: RandyMcMillan

src/qt/mempooldetail.cpp

@@ -101,7 +101,8 @@ void MempoolDetail::setPlatformStyle(const PlatformStyle* platform_style)
     m_tx_table->setSelectionMode(QAbstractItemView::SingleSelection);
     m_tx_table->setAlternatingRowColors(true);
     m_tx_table->setStyleSheet("QTableView { background-color: transparent; border: 1px solid gray; border-radius: 5px; }");
-    m_tx_table->setSortingEnabled(false); // Sorting not implemented for this model yet
+    m_tx_table->setSortingEnabled(true);
+    m_tx_table->sortByColumn(m_tx_table_model->m_sort_column, m_tx_table_model->m_sort_order);
     m_tx_table->verticalHeader()->setVisible(false);
     m_tx_table->horizontalHeader()->setStretchLastSection(true);
 

src/qt/mempooltxtables.cpp

@@ -13,6 +13,7 @@
 MempoolTxTableModel::MempoolTxTableModel(QObject* parent)
     : QAbstractTableModel(parent)
 {
+    m_sort_column = TxID;
 }
 
 MempoolTxTableModel::~MempoolTxTableModel() = default;
@@ -116,6 +117,45 @@ QModelIndex MempoolTxTableModel::index(int row, int column, const QModelIndex& p
     return QModelIndex();
 }
 
+void MempoolTxTableModel::sort(int column, Qt::SortOrder order)
+{
+    m_sort_column = column;
+    m_sort_order = order;
+    beginResetModel();
+    std::sort(m_tx_data.begin(), m_tx_data.end(),
+        [&](const interfaces::WalletTx& a, const interfaces::WalletTx& b) {
+            if (order == Qt::AscendingOrder) {
+                switch (static_cast<ColumnIndex>(column)) {
+                case TxID:
+                    return a.tx->GetHash().ToString() < b.tx->GetHash().ToString();
+                case Amount:
+                    return (a.credit - a.debit) < (b.credit - b.debit);
+                case Fee:
+                    return (a.debit - a.credit - a.change) < (b.debit - b.credit - b.change);
+                case Status:
+                    return false; // Status is not meaningfully sortable, maintain current order
+                default:
+                    return false;
+                }
+            } else { // DescendingOrder
+                switch (static_cast<ColumnIndex>(column)) {
+                case TxID:
+                    return a.tx->GetHash().ToString() > b.tx->GetHash().ToString();
+                case Amount:
+                    return (a.credit - a.debit) > (b.credit - b.debit);
+                case Fee:
+                    return (a.debit - a.credit - a.change) > (b.debit - b.credit - b.change);
+                case Status:
+                    return false; // Status is not meaningfully sortable, maintain current order
+                default:
+                    return false;
+                }
+            }
+            return false; // Should not be reached
+        });
+    endResetModel();
+}
+
 void MempoolTxTableModel::updateModel(const std::set<interfaces::WalletTx>& wallet_transactions, bool has_active_wallet)
 {
     beginResetModel();
@@ -134,5 +174,8 @@ void MempoolTxTableModel::updateModel(const std::set<interfaces::WalletTx>& wall
         // We'll rely on that for now, or add a similar check here if needed.
         m_tx_data.append(wtx);
     }
+    if (m_sort_column != -1) {
+        sort(m_sort_column, m_sort_order);
+    }
     endResetModel();
 }

src/qt/mempooltxtables.h

@@ -41,13 +41,16 @@ class MempoolTxTableModel : public QAbstractTableModel
     QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
     QModelIndex index(int row, int column, const QModelIndex& parent = QModelIndex()) const override;
     Qt::ItemFlags flags(const QModelIndex &index) const override;
+    void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) override;
     /*@}*/
 
 public Q_SLOTS:
     void updateModel(const std::set<interfaces::WalletTx>& wallet_transactions, bool has_active_wallet);
 
-private:
+public:
     QList<interfaces::WalletTx> m_tx_data;
+    int m_sort_column = -1;
+    Qt::SortOrder m_sort_order = Qt::AscendingOrder;
     const QStringList columns{
         /*: Title of Mempool Tx Table column which contains the transaction ID. */
         tr("TXID"),