Skip to content

Commit 3729a0e

Browse files
committed
change inconsistent array param to pointer
The behavior is identical, but the former syntax suggests guarantees that don't actually exist.
1 parent 05bfab6 commit 3729a0e

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/scalar_4x64_impl.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ static void secp256k1_scalar_reduce_512(secp256k1_scalar *r, const uint64_t *l)
681681
secp256k1_scalar_reduce(r, c + secp256k1_scalar_check_overflow(r));
682682
}
683683

684-
static void secp256k1_scalar_mul_512(uint64_t l[8], const secp256k1_scalar *a, const secp256k1_scalar *b) {
684+
static void secp256k1_scalar_mul_512(uint64_t *l8, const secp256k1_scalar *a, const secp256k1_scalar *b) {
685685
#ifdef USE_ASM_X86_64
686686
const uint64_t *pb = b->d;
687687
__asm__ __volatile__(
@@ -812,7 +812,7 @@ static void secp256k1_scalar_mul_512(uint64_t l[8], const secp256k1_scalar *a, c
812812
/* Extract l7 */
813813
"movq %%r8, 56(%%rsi)\n"
814814
: "+d"(pb)
815-
: "S"(l), "D"(a->d)
815+
: "S"(l8), "D"(a->d)
816816
: "rax", "rbx", "rcx", "r8", "r9", "r10", "r11", "r12", "r13", "r14", "r15", "cc", "memory");
817817
#else
818818
/* 160 bit accumulator. */
@@ -821,30 +821,30 @@ static void secp256k1_scalar_mul_512(uint64_t l[8], const secp256k1_scalar *a, c
821821

822822
/* l[0..7] = a[0..3] * b[0..3]. */
823823
muladd_fast(a->d[0], b->d[0]);
824-
extract_fast(l[0]);
824+
extract_fast(l8[0]);
825825
muladd(a->d[0], b->d[1]);
826826
muladd(a->d[1], b->d[0]);
827-
extract(l[1]);
827+
extract(l8[1]);
828828
muladd(a->d[0], b->d[2]);
829829
muladd(a->d[1], b->d[1]);
830830
muladd(a->d[2], b->d[0]);
831-
extract(l[2]);
831+
extract(l8[2]);
832832
muladd(a->d[0], b->d[3]);
833833
muladd(a->d[1], b->d[2]);
834834
muladd(a->d[2], b->d[1]);
835835
muladd(a->d[3], b->d[0]);
836-
extract(l[3]);
836+
extract(l8[3]);
837837
muladd(a->d[1], b->d[3]);
838838
muladd(a->d[2], b->d[2]);
839839
muladd(a->d[3], b->d[1]);
840-
extract(l[4]);
840+
extract(l8[4]);
841841
muladd(a->d[2], b->d[3]);
842842
muladd(a->d[3], b->d[2]);
843-
extract(l[5]);
843+
extract(l8[5]);
844844
muladd_fast(a->d[3], b->d[3]);
845-
extract_fast(l[6]);
845+
extract_fast(l8[6]);
846846
VERIFY_CHECK(c1 == 0);
847-
l[7] = c0;
847+
l8[7] = c0;
848848
#endif
849849
}
850850

0 commit comments

Comments
 (0)