Skip to content

Commit e2f10b4

Browse files
committed
Merge #34: win32: fix -Wmissing-field-initializers warnings
12c52b3 win32: fix -Wmissing-field-initializers warnings (fanquake) Pull request description: When building with `-Wmissing-field-initializers`, the following warning is emitted: ```bash leveldb/util/env_windows.cc: In member function ‘virtual leveldb::Status leveldb::{anonymous}::WindowsRandomAccessFile::Read(uint64_t, size_t, leveldb::Slice*, char*) const’: leveldb/util/env_windows.cc:197:31: warning: missing initializer for member ‘_OVERLAPPED::InternalHigh’ [-Wmissing-field-initializers] 197 | OVERLAPPED overlapped = {0}; | ^ leveldb/util/env_windows.cc:197:31: warning: missing initializer for member ‘_OVERLAPPED::<anonymous>’ [-Wmissing-field-initializers] leveldb/util/env_windows.cc:197:31: warning: missing initializer for member ‘_OVERLAPPED::hEvent’ [-Wmissing-field-initializers] ``` Submitted upstream: google#1053 ACKs for top commit: sipsorcery: ACK 12c52b3. hebasto: ACK 12c52b3, I have reviewed the code and it looks OK. theuni: ACK 12c52b3 Tree-SHA512: be8590f37c21af2ed5e77ebd5fdf6c5da1cba1e72c46c241202b4dfbcd3667e1aa2522b303eaa9c1e5d6a61290dd268e76c0a1e42df6bf5734c775ca6b2dbdf2
2 parents 22f1e4a + 12c52b3 commit e2f10b4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

util/env_windows.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ class WindowsRandomAccessFile : public RandomAccessFile {
194194
Status Read(uint64_t offset, size_t n, Slice* result,
195195
char* scratch) const override {
196196
DWORD bytes_read = 0;
197-
OVERLAPPED overlapped = {0};
197+
OVERLAPPED overlapped = {};
198198

199199
overlapped.OffsetHigh = static_cast<DWORD>(offset >> 32);
200200
overlapped.Offset = static_cast<DWORD>(offset);

0 commit comments

Comments
 (0)