Skip to content

Commit f2066ea

Browse files
committed
[build] enable external signer by default for GUI
1 parent ab534ca commit f2066ea

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

ci/test/00_setup_env_win64.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ export PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64"
1313
export RUN_FUNCTIONAL_TESTS=false
1414
export RUN_SECURITY_TESTS="true"
1515
export GOAL="deploy"
16-
export BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests --without-boost-process"
16+
export BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests --disable-external-signer"

configure.ac

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -140,18 +140,6 @@ AC_ARG_ENABLE([upnp-default],
140140
[use_upnp_default=$enableval],
141141
[use_upnp_default=no])
142142

143-
dnl Enable external signer support when opting in to boost process (and not opting out of wallet)
144-
if test x$with_boost_process = xyes && test x$enable_wallet != xno; then
145-
use_external_signer_default=yes;
146-
else
147-
use_external_signer_default=no;
148-
fi
149-
150-
AC_ARG_ENABLE([external-signer],
151-
[AS_HELP_STRING([--enable-external-signer],[compile external signer support (requires Boost::Process)])],
152-
[use_external_signer=$enableval],
153-
[use_external_signer=$use_external_signer_default])
154-
155143
AC_ARG_ENABLE(tests,
156144
AS_HELP_STRING([--disable-tests],[do not compile tests (default is to compile)]),
157145
[use_tests=$enableval],
@@ -1185,6 +1173,18 @@ else
11851173
BITCOIN_QT_CONFIGURE([5.5.1])
11861174
fi
11871175

1176+
dnl Enable external signer support when opting in to boost process, or building GUI, but not opting out of wallet)
1177+
if (test x$with_boost_process = xyes || test x$bitcoin_enable_qt != xno) && test x$enable_wallet != xno; then
1178+
use_external_signer_default=yes;
1179+
else
1180+
use_external_signer_default=no;
1181+
fi
1182+
1183+
AC_ARG_ENABLE([external-signer],
1184+
[AS_HELP_STRING([--enable-external-signer],[compile external signer support (requires Boost::Process)])],
1185+
[use_external_signer=$enableval],
1186+
[use_external_signer=$use_external_signer_default])
1187+
11881188
if test x$enable_wallet != xno; then
11891189
dnl Check for libdb_cxx only if wallet enabled
11901190
BITCOIN_FIND_BDB48

0 commit comments

Comments
 (0)