Skip to content

Commit bb46014

Browse files
committed
qt, test: use qsignalspy instead of qeventloop
1 parent ecf5f2c commit bb46014

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/qt/test/apptests.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020
#endif
2121

2222
#include <QAction>
23-
#include <QEventLoop>
2423
#include <QLineEdit>
2524
#include <QScopedPointer>
25+
#include <QSignalSpy>
2626
#include <QTest>
2727
#include <QTextEdit>
2828
#include <QtGlobal>
@@ -33,13 +33,12 @@ namespace {
3333
//! Call getblockchaininfo RPC and check first field of JSON output.
3434
void TestRpcCommand(RPCConsole* console)
3535
{
36-
QEventLoop loop;
3736
QTextEdit* messagesWidget = console->findChild<QTextEdit*>("messagesWidget");
38-
QObject::connect(messagesWidget, &QTextEdit::textChanged, &loop, &QEventLoop::quit);
3937
QLineEdit* lineEdit = console->findChild<QLineEdit*>("lineEdit");
38+
QSignalSpy mw_spy(messagesWidget, &QTextEdit::textChanged);
4039
QTest::keyClicks(lineEdit, "getblockchaininfo");
4140
QTest::keyClick(lineEdit, Qt::Key_Return);
42-
loop.exec();
41+
QVERIFY(mw_spy.wait(1000));
4342
QString output = messagesWidget->toPlainText();
4443
UniValue value;
4544
value.read(output.right(output.size() - output.lastIndexOf(QChar::ObjectReplacementCharacter) - 1).toStdString());

0 commit comments

Comments
 (0)