Skip to content

Commit 29e6a9d

Browse files
committed
[build] enable external signer by default for GUI
1 parent 75fd1c2 commit 29e6a9d

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

ci/test/00_setup_env_win64.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ export PACKAGES="python3 nsis g++-mingw-w64-x86-64 wine-binfmt wine64"
1313
export RUN_FUNCTIONAL_TESTS=false
1414
export RUN_SECURITY_TESTS="true"
1515
export GOAL="deploy"
16-
export BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests --without-boost-process"
16+
export BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests --disable-external-signer"

configure.ac

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -133,18 +133,6 @@ AC_ARG_ENABLE([upnp-default],
133133
[use_upnp_default=$enableval],
134134
[use_upnp_default=no])
135135

136-
dnl Enable external signer support when opting in to boost process (and not opting out of wallet)
137-
if test x$with_boost_process = xyes && test x$enable_wallet != xno; then
138-
use_external_signer_default=yes;
139-
else
140-
use_external_signer_default=no;
141-
fi
142-
143-
AC_ARG_ENABLE([external-signer],
144-
[AS_HELP_STRING([--enable-external-signer],[compile external signer support (requires Boost::Process)])],
145-
[use_external_signer=$enableval],
146-
[use_external_signer=$use_external_signer_default])
147-
148136
AC_ARG_ENABLE(tests,
149137
AS_HELP_STRING([--disable-tests],[do not compile tests (default is to compile)]),
150138
[use_tests=$enableval],
@@ -1152,6 +1140,18 @@ else
11521140
BITCOIN_QT_CONFIGURE
11531141
fi
11541142

1143+
dnl Enable external signer support when opting in to boost process, or building GUI, but not opting out of wallet)
1144+
if (test x$with_boost_process = xyes || test x$bitcoin_enable_qt != xno) && test x$enable_wallet != xno; then
1145+
use_external_signer_default=yes;
1146+
else
1147+
use_external_signer_default=no;
1148+
fi
1149+
1150+
AC_ARG_ENABLE([external-signer],
1151+
[AS_HELP_STRING([--enable-external-signer],[compile external signer support (requires Boost::Process)])],
1152+
[use_external_signer=$enableval],
1153+
[use_external_signer=$use_external_signer_default])
1154+
11551155
if test x$enable_wallet != xno; then
11561156
dnl Check for libdb_cxx only if wallet enabled
11571157
BITCOIN_FIND_BDB48

0 commit comments

Comments
 (0)