Add validation to the Send form (address and amount) #462

johnny9 · 2025-06-01T17:44:50Z

This is built on top of #450 so when reviewing, its best to select just the new commits in the "Files changed" tab.

These changes add properties for the error strings used in the QML to SendRecipient and add validation methods that are checked when the relevant properties are changed by the user.

src/qml/models/sendrecipient.cpp

src/qml/models/sendrecipient.h

goqusan · 2025-06-02T08:12:02Z

src/qml/models/sendrecipient.cpp

+            setAmountError(tr("Amount must be greater than zero"));
+        } else if (m_amount->satoshi() > MAX_MONEY) {
+            setAmountError(tr("Amount exceeds maximum limit"));
+        } else if (m_amount->satoshi() > m_wallet->balanceSatoshi()) {


could remove this case for now as it allows removing the circular dependency?

I think this might be a good idea and I can just do this validation when creating the transaction in the wallet model

I think im going to leave the circular dependency in for now.and take another look when doing validation with multiple recipients

GBKS · 2025-06-02T12:31:08Z

Nice addition. A few notes:

Can we restrict the character input altogether, so I can only enter numbers (and periods/commas) in the amount field and only allowed characters in the address field?
We should also add a max length. I think 62 is max for addresses, and 17 for bitcoin amounts (21000000.00000000). Not 100% on those numbers. Either way, right now I can type in infinite characters, so some restriction would be good.
I was not able to get any address to validate (grabbed a few different address types from here).
I see the error "Amount exceeds maximum limit". Would be more useful if it states the limit, like "The maximum is 21,000,000." or so - sneak in the supply cap.
When I enter a huge number and deselect the field, the number changes. Not sure why, and I could not find a pattern how it changes.
For an empty wallet, there is the question whether the Send form should be enabled at all.

Always a bit finicky these input fields.

MarnixCroes

1e81bb6

the UX is better if the verification is done without having to change focus from the field:

Screencast.from.2025-06-02.13-12-13.webm

the amount converter doesn't seem to be working as it should:

Screencast.from.2025-06-02.13-14-41.webm

johnny9 · 2025-06-03T14:56:13Z

1e81bb6

* the UX is better if the verification is done without having to change focus from the field:

Good catch, I will split up the validation and formatting helpers so that validation can happen while editing and it will reformat once editing is finished.

Screencast.from.2025-06-02.13-12-13.webm
* the amount converter doesn't seem to be working as it should:
Screencast.from.2025-06-02.13-14-41.webm

bummer, must have introduced a bug with conversion. I will double check the sats to btc conversion.

johnny9 · 2025-06-03T15:00:23Z

Nice addition. A few notes:

Can we restrict the character input altogether, so I can only enter numbers (and periods/commas) in the amount field and only allowed characters in the address field?
Yes, I can add validators to restrict inputs into this form

We should also add a max length. I think 62 is max for addresses, and 17 for bitcoin amounts (21000000.00000000). Not 100% on those numbers. Either way, right now I can type in infinite
characters, so some restriction would be good.

I will look at what options there are to restrict the character limit

I was not able to get any address to validate (grabbed a few different address types from here).

Thats interesting. I will double check. Could it be regtest/testnet/mainnet differences in format.

I see the error "Amount exceeds maximum limit". Would be more useful if it states the limit, like "The maximum is 21,000,000." or so - sneak in the supply cap.

I can update the error string to include this

When I enter a huge number and deselect the field, the number changes. Not sure why, and I could not find a pattern how it changes.

This is a precursor to what will end up being the rich formatting of the amount. If you are inputing BTC amounts it will add the satoshi trailing 0's

For an empty wallet, there is the question whether the Send form should be enabled at all.

Always a bit finicky these input fields.

I will consider this.

The SendRecipientsListModel is owned by WalletQmlModel

This merges BitcoinAmount with SendRecipient to simplify the qml logic. By doing so, the conversions can be managed all in c++ against the satoshi member variable. Each recipient having its own BitcoinAmount allows the amounts to be saved independantly when there are multiple recipients.

johnny9 · 2025-06-04T04:39:57Z

Update from 1e81bb6 to a5aba54

rebased with main

…network

MarnixCroes

tested LGTM 3630bc2

Note that when entering full balance, Review is highlighted but not clickable.

As the GUI won't allow creating tx's with 0 fees, maybe Review should only be highlighted when amount < balance

GBKS · 2025-06-05T09:59:46Z

Looking good.

Address input

I just fixed some of the input logic in the prototype, so it properly breaks into multiple lines and applies for formatting. Not sure if you're referencing that right now or not.

Amount input

Do we need to force the 8 decimals for bitcoin amounts? Seems easier to just have 0.1 rather than 0.10000000.
The unit toggle needs hover states
As I mentioned before, when the amount exceeds the balance, we discussed showing Balance: 0,00348200 ₿. Send max., where Send max is underlined and a button that inserts the full balance into the input field. I have this partially working in the prototype, but need to fix some logic. Gets a little tricky when we also have the Include fee in amount toggle and multiple recipients. Maybe something for a separate PR?

johnny9 · 2025-06-05T19:57:34Z

tested LGTM 3630bc2

Note that when entering full balance, Review is highlighted but not clickable.

As the GUI won't allow creating tx's with 0 fees, maybe Review should only be highlighted when amount < balance

This is a good one. I will add an issue to include this in my validation when I add proper fee estimation.

johnny9 force-pushed the send-validation branch 2 times, most recently from 666aff7 to 1e81bb6 Compare June 1, 2025 20:59

goqusan reviewed Jun 2, 2025

View reviewed changes

MarnixCroes reviewed Jun 2, 2025

View reviewed changes

johnny9 mentioned this pull request Jun 3, 2025

Connect Receive page to WalletQmlModel and Cleanup Layouts #464

Open

johnny9 added 15 commits June 4, 2025 00:38

qml: Introduce SendRecipientsListModel

e79588b

The SendRecipientsListModel is owned by WalletQmlModel

qml: Add Multiple Recipients toggle to Send menu

7f16391

qml: Add Multiple Recipients bar to Send form

a4efd63

qml: Reduce size of recipient selectors

c2bb783

qml: Add remove button to multiple recipients

6ee0284

qml: Prepare transaction with recipients list

a9acdf0

qml: Add MultipleSendReview page

53c7bbc

qml: Add plus big filled icon

eea58e4

qml: Replace NavButton with IconButton in Send

6613d40

qml: Add total calculation to SendRecipientsListModel

72c3a9b

qml: Commit Recipient amount when active focus is lost

a5fd44e

qml: Clear Send form after sending transaciton

eec0763

qml: Add alert icon

7c4252d

qml: Add validation to Send form address and amount

a5aba54

johnny9 force-pushed the send-validation branch from 1e81bb6 to a5aba54 Compare June 4, 2025 04:39

johnny9 added 5 commits June 4, 2025 01:11

qml: Split amount and display updating for Bitcoin amount input

2c8ce2c

qml: Add validators to address and amount inputs to limit characters

ccb0622

qml: Add maximum length for address input

289cbcc

qml: Specify maximum BTC amount in error string

7e94eb8

qml: Don't set/clear error string unless needed

6a2e6d0

qml: Add const to sendrecipient's m_wallet

f1ad73a

johnny9 force-pushed the send-validation branch from 6991ba5 to f1ad73a Compare June 4, 2025 05:29

qml: Provide information if the supplied addres is valid for another …

3630bc2

…network

MarnixCroes reviewed Jun 4, 2025

View reviewed changes

This was referenced Jun 5, 2025

Amount validation in Send form is not taking into account the fee #467

Open

Add Multiple Recipients option to the Send form #450

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add validation to the Send form (address and amount) #462

Add validation to the Send form (address and amount) #462

Uh oh!

johnny9 commented Jun 1, 2025

Uh oh!

Uh oh!

Uh oh!

goqusan Jun 2, 2025

Uh oh!

johnny9 Jun 3, 2025

Uh oh!

johnny9 Jun 4, 2025

Uh oh!

GBKS commented Jun 2, 2025

Uh oh!

MarnixCroes left a comment

Uh oh!

johnny9 commented Jun 3, 2025

Uh oh!

johnny9 commented Jun 3, 2025

Uh oh!

johnny9 commented Jun 4, 2025

Uh oh!

MarnixCroes left a comment

Uh oh!

GBKS commented Jun 5, 2025

Uh oh!

johnny9 commented Jun 5, 2025

Uh oh!

Uh oh!

Add validation to the Send form (address and amount) #462

Are you sure you want to change the base?

Add validation to the Send form (address and amount) #462

Uh oh!

Conversation

johnny9 commented Jun 1, 2025

Uh oh!

Uh oh!

Uh oh!

goqusan Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

johnny9 Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

johnny9 Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

GBKS commented Jun 2, 2025

Uh oh!

MarnixCroes left a comment

Choose a reason for hiding this comment

Uh oh!

johnny9 commented Jun 3, 2025

Uh oh!

johnny9 commented Jun 3, 2025

Uh oh!

johnny9 commented Jun 4, 2025

Uh oh!

MarnixCroes left a comment

Choose a reason for hiding this comment

Uh oh!

GBKS commented Jun 5, 2025

Uh oh!

johnny9 commented Jun 5, 2025

Uh oh!

Uh oh!