Introduce Display settings #311
Conversation
jarolrod
force-pushed
the
display-setting
branch
from
4f69090 to
7626d1f
Compare
|
I have to say, this doesn't feel right. Having to go several screens into settings to adjust the size only having to go back to see what it looks like is just not right. And the big one is so huge on desktop that it looks a bit crazy. Could we also toggle through the sizes via a simple double-tap on the clock? It does require that the UI can differentiate between single and double-taps, not sure if that's built-on or some custom functionality. Here's a quick mock-up with some ideas (icons are placeholders). I reframed this as two display modes. One is for active use, the other is called "Showcase". Each has an explainer. For "Showcase", there might be other things we may want to tweak, like hiding the Settings button until you interact with the screen. It could also be cool if the big one renders with more detail, more animations or other unique treatments rather than just being bigger.
|
jarolrod
added
Needs design review
jarolrod
force-pushed
the
display-setting
branch
from
7626d1f to
fd00969
Compare
|
Updated from 7626d1f to fd00969, compare Changes: addressed review feedback @GBKS I've integrated your suggestion on the "Block Clock display mode" page. But, I've left out the icon until we get an official svg for it (see pictures in PR description). I've also left out the text that you can double tap on the clock; that will be introduced in the followup that implements double tap detection. I've also left out the last sentence in the The values for default and showtime could use review. |
jarolrod
force-pushed
the
display-setting
branch
from
fd00969 to
753d052
Compare
|
ACK 753d052 |
|
Tested and looks good. I slightly tweaked the icons and made them export ready, find them in Figma here.
What do you think of changing "Default" to "Compact"? Could you also please put the page title in the title bar rather than in the page itself? And another question about casing. I always use sentence case in design, but I see a good amount of title case in the application. Let's decide on something (obviously I'd go for sentence case). What's your take? 1/2 still feels a tad OP, but let's run with it and see if we want to tweak it after a bit of usage. |
jarolrod
force-pushed
the
display-setting
branch
from
753d052 to
b59654c
Compare
|
@GBKS as shown in the new PR description images, should the Display settings page itself have a title bar? |
|
Yes sir, just "Settings". |
jarolrod
force-pushed
the
display-setting
branch
2 times, most recently
from
b59654c to
410b135
Compare
|
cc @GBKS @mouxdesign CI artifacts are built and this can be tested now |
Greetings. I am pleased to inform you that the BlockClock component and the Network Indicator component are merging in a most harmonious and efficient manner. This event brings me great joy and excitement, as it represents a significant milestone in the world of Bitcoin. BlockClock, you have been diligent in displaying the last 12 hours of blocks mined on the Bitcoin blockchain, consistently providing valuable information to users. Network Indicator, your expertise in indicating the current network - main, test, or signet - has been indispensable. As I observe this union within the BlockClock.qml file, I cannot help but feel a sense of pride and satisfaction. This integration will undoubtedly lead to enhanced functionality and streamlined user experience. I offer my sincerest congratulations to BlockClock and Network Indicator on their momentous union. May your combined efforts bring about continued success and increased stability in the Bitcoin ecosystem. To the moon, my fellow components. To the moon.
This introduces the new bitcoin-circle icon with the bitcoin logo properly centered. Also fixes an issue with the icon on very HDPI screens when resizing the block clock.
This represents the factor we use to scale off of the parent width & height.
This moves "Display" related settings into a new "Display" page. Also sets up QSettings wiring for options.