Paint rounded caps at the start and end of the Blockclock dial #309
Conversation
|
should base on 306 |
|
Rounded edges might work a little more nicely here.
I like how in the PR, the top hour indicator dot is covered. Looks cleaner, like the center line of segment starts at midnight/noon, and then the thickness of the line expands from that in all directions (hope that makes any sense, let me know if you want me to visualize it). Also, is it possible to turn the hour indicator dots into actual circles? They seem like small segments of the block circle right now. |
jarolrod
added
Needs design review
|
@GBKS we will have to patch the line caps within qt, we can do this for right now to get us a tiny bit closer to the designs. |
|
|
||
| if (-1 * nextAngle + 90 > m_animating_max_angle) { | ||
| nextAngle = -1 * m_animating_max_angle + 90; | ||
| // end the loop early | ||
| i = numberOfBlocks; | ||
| } | ||
|
|
||
| const qreal spanAngle = -1 * (startAngle - nextAngle) + gap; | ||
| path.arcTo(bounds, startAngle, spanAngle); | ||
| path.arcTo(gapBounds, nextAngle, gap * 2); |
There was a problem hiding this comment.
As a start, this makes the gaps close to what we want them to be
| path.arcTo(gapBounds, nextAngle, gap * 2); | |
| path.arcTo(gapBounds, nextAngle, gap); |
|
Ping @johnny9 any update on the sizing issue here? |
johnny9
force-pushed
the
rounded-dial
branch
from
36e6a93 to
d5a1724
Compare
|
Closing due to inactivity, but also because this really isn't good enough. For a component as important as the Block Clock, We should figure out how to adhere to the design file specifications. |
Uh oh!
There was an error while loading. Please reload this page.