Skip to content

Smart storage values based on assumed chain and chainstate values #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Mar 1, 2023

When a prune target is set, that limits how much storage is taken up by blocks. But there is still other data such as the chainstate. This moves us away from wrongly conveying that the prune target is how much data will be taken up, and instead conveys how much data will be taken up considering the prune target, assumed blockchain size, and assumed chainstate size. The assumed sizes are updated every release cycle.

Changes:

  • Storage Location

    • The text that shows what the minimum amount of space needed is now displays assumed chainstate size + 1GB instead of just 1GB
  • Storage Options

    • The default prune button is now 2GB + assumed chainstate size instead of just the prune target of 2GB
    • Store all data button is now the assumed blockchain size + assumed chainstate size instead of a hardcoded 550GB
    • Custom Prune button is now the prune target + assumed chainstate size instead of just the prune target set in detailed settings
  • Storage Settings

    • The text of the Setting which is used to set a custom prune target is changed from "Storage limit (GB)" to "Block Storage limit (GB)" to convey this controls block storage specifically. The Custom prune button that then appears on the storage options page shows this prune target + assumed chainstate size

Master

Storage Location Storage Storage Settings Custom Prune
storage-location-master storage-master storage-setting-master custom-prune-master

PR

Storage Location Storage Storage Settings Custom Prune
storage-location-pr storage-pr storage-settings-pr custom-prune-pr

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@jarolrod jarolrod force-pushed the smart-blockchain-size branch from b1c639b to 5ead189 Compare March 15, 2023 06:05
@jarolrod
Copy link
Member Author

Updated from b1c639b to 5ead189, Compare

  • Changes: rebased over main

@jarolrod
Copy link
Member Author

cc @johnny9 @hebasto

Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5ead189

@hebasto hebasto merged commit 33d1751 into bitcoin-core:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants