Skip to content

Introduce the Peers page #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2023
Merged

Introduce the Peers page #259

merged 2 commits into from
Feb 17, 2023

Conversation

johnny9
Copy link
Collaborator

@johnny9 johnny9 commented Feb 13, 2023 •
edited
Loading

Adds a new page under Node settings that shows a list of connected peers. A ProxyModel is added to translate the original PeerTableModel into a model that the ListView can handle.

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

Screenshot from 2023-02-12 22-38-10
Screenshot from 2023-02-12 22-38-30

@johnny9 johnny9 force-pushed the peers branch 5 times, most recently from d820174 to d0c72f8 Compare February 13, 2023 04:07
@johnny9
Copy link
Collaborator Author

johnny9 commented Feb 13, 2023

Update from d820174 to d0c72f8:

  • fix whitespace lint errors

@hebasto hebasto changed the title qml: Introduce the Peers page Introduce the Peers page Feb 13, 2023
@jarolrod jarolrod mentioned this pull request Feb 15, 2023
Closed
@johnny9
Copy link
Collaborator Author

johnny9 commented Feb 16, 2023 •
edited
Loading

Update from d0c72f8 to 46615f:

  • Rebased with main
  • Used the Separator component in the ListView layout
  • Included a footer that shows the PeersIndicator as well as text describing the how many more peers until max

Screenshot from 2023-02-15 20-01-52

jarolrod
jarolrod reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking perfect, just missed one thing

@johnny9
Copy link
Collaborator Author

johnny9 commented Feb 16, 2023

Update from 46615ff to c9aaeae:

  • squashed Separator changes into the original commit
  • Included separator in NodeSettings Peers link
  • Used CaretRightButton in NodeSettings Peers link

jarolrod
jarolrod approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c9aaeae

tested on macOS, linux, and Android

@jarolrod jarolrod mentioned this pull request Feb 17, 2023
Closed
@hebasto hebasto merged commit b29d499 into bitcoin-core:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarolrod jarolrod jarolrod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnny9 @jarolrod @hebasto