Skip to content

Blockclock connecting state #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Feb 9, 2023

Wires logic so that the connecting state for the block clock will actually show when the node is finding peers

Screen Shot 2023-02-08 at 11 52 38 PM

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

@hebasto
Copy link
Member

hebasto commented Feb 9, 2023

Based on #236

It has been just merged. Rebase?

@jarolrod jarolrod force-pushed the blockclock-connecting-state branch from da46d4e to 0411eec Compare February 9, 2023 08:54
@jarolrod
Copy link
Member Author

jarolrod commented Feb 9, 2023

Updated from da46d4e to 0411eec, compare

changes:

  • rebased over main
  • dropped changes that set connected inside blockclockdial.cpp/h as that's not needed

@jarolrod
Copy link
Member Author

jarolrod commented Feb 9, 2023

Missing the connecting spinning animation on the dial, someone can pick that up later

@hebasto
Copy link
Member

hebasto commented Feb 9, 2023

Once more rebase?

@jarolrod jarolrod force-pushed the blockclock-connecting-state branch from 0411eec to e3e7b4c Compare February 9, 2023 20:12
@jarolrod
Copy link
Member Author

jarolrod commented Feb 9, 2023

Updated from 0411eec to e3e7b4c, compare

changes: rebased over main

Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e3e7b4c

@hebasto hebasto merged commit 29c4a9f into bitcoin-core:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants