Skip to content

Only show Onboarding if settings file is missing #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

johnny9
Copy link
Collaborator

@johnny9 johnny9 commented Feb 5, 2023

Commit adds a context property that is used to determine if Onboarding flow is needed. If the user supplies a data directory or their settings.json file is missing, the property "needOnboarding" will be set to true.

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK!

@jarolrod jarolrod mentioned this pull request Feb 5, 2023
@johnny9
Copy link
Collaborator Author

johnny9 commented Feb 6, 2023

Update from 46b1904 to 27c38a9:

  • Check if datadir argument is not empty
  • Check if bitcoin.conf exists

@hebasto hebasto changed the title qml: only show Onboarding if settings file is missing Only show Onboarding if settings file is missing Feb 7, 2023
@hebasto
Copy link
Member

hebasto commented Feb 7, 2023

FWIW, the relevant Qt widget GUI logic is implemented in

bool Intro::showIfNeeded(bool& did_show_intro, int64_t& prune_MiB)

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 27c38a9

A follow-up can allow QSettings to override the default data dir, QSettings needs to be wired up first.

@hebasto hebasto merged commit 8c672b8 into bitcoin-core:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants