Skip to content

Add ContinueButton interaction color animation states #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2023
Merged

Add ContinueButton interaction color animation states #232

merged 1 commit into from
Jan 29, 2023

Conversation

jarolrod
Copy link
Member

@jarolrod jarolrod commented Jan 28, 2023 •
edited
Loading

Introduces the missing ContinueButton interaction color animation states as detailed in #229

Dark Mode

Default Hovered Pressed
Screen Shot 2023-01-28 at 6 21 06 PM Screen Shot 2023-01-28 at 6 21 25 PM Screen Shot 2023-01-28 at 6 21 40 PM

Light Mode

Default Hovered Pressed
Screen Shot 2023-01-28 at 6 22 32 PM Screen Shot 2023-01-28 at 6 22 53 PM Screen Shot 2023-01-28 at 6 23 03 PM

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

Closes #229

@jarolrod
Copy link
Member Author

@GBKS are orangeLight1 and orangeLight2 supposed to be the same between dark and light mode?

@jarolrod jarolrod marked this pull request as draft January 29, 2023 00:24
@jarolrod jarolrod force-pushed the continue-button-states branch from 878ebab to 39b4c15 Compare January 29, 2023 00:57
@jarolrod jarolrod marked this pull request as ready for review January 29, 2023 00:58
@jarolrod
Copy link
Member Author

Updated from 878ebab to 39b4c15, compare

changes: addressed issue where the button background color would not update after a theme switch.

johnny9
johnny9 approved these changes Jan 29, 2023
View reviewed changes
Copy link
Collaborator

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 39b4c15

Button behaves as expected and no QML errors.

@hebasto hebasto merged commit 075e216 into bitcoin-core:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnny9 johnny9 johnny9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Continue Button states in adherance to the design file specifications
3 participants
@jarolrod @johnny9 @hebasto