Remove dead branches (#344)

* Indices are always numbers

* Arrays are never strings

* key cannot be number

Author: Methuselah96

src/filters/arrays.js

@@ -50,28 +50,18 @@ function matchItems(array1, array2, index1, index2, context) {
     // no way to match objects was provided, try match by position
     return context.matchByPosition && index1 === index2;
   }
-  let hash1;
-  let hash2;
-  if (typeof index1 === 'number') {
-    context.hashCache1 = context.hashCache1 || [];
-    hash1 = context.hashCache1[index1];
-    if (typeof hash1 === 'undefined') {
-      context.hashCache1[index1] = hash1 = objectHash(value1, index1);
-    }
-  } else {
-    hash1 = objectHash(value1);
+  context.hashCache1 = context.hashCache1 || [];
+  let hash1 = context.hashCache1[index1];
+  if (typeof hash1 === 'undefined') {
+    context.hashCache1[index1] = hash1 = objectHash(value1, index1);
   }
   if (typeof hash1 === 'undefined') {
     return false;
   }
-  if (typeof index2 === 'number') {
-    context.hashCache2 = context.hashCache2 || [];
-    hash2 = context.hashCache2[index2];
-    if (typeof hash2 === 'undefined') {
-      context.hashCache2[index2] = hash2 = objectHash(value2, index2);
-    }
-  } else {
-    hash2 = objectHash(value2);
+  context.hashCache2 = context.hashCache2 || [];
+  let hash2 = context.hashCache2[index2];
+  if (typeof hash2 === 'undefined') {
+    context.hashCache2[index2] = hash2 = objectHash(value2, index2);
   }
   if (typeof hash2 === 'undefined') {
     return false;

src/filters/lcs.js

@@ -81,11 +81,7 @@ const get = function (array1, array2, match, context) {
     match || defaultMatch,
     innerContext,
   );
-  const result = backtrack(matrix, array1, array2, innerContext);
-  if (typeof array1 === 'string' && typeof array2 === 'string') {
-    result.sequence = result.sequence.join('');
-  }
-  return result;
+  return backtrack(matrix, array1, array2, innerContext);
 };
 
 export default {

src/formatters/base.js

@@ -182,11 +182,7 @@ class BaseFormatter {
       if (arrayKeys && key === '_t') {
         continue;
       }
-      const leftKey = arrayKeys
-        ? typeof key === 'number'
-          ? key
-          : parseInt(trimUnderscore(key), 10)
-        : key;
+      const leftKey = arrayKeys ? parseInt(trimUnderscore(key), 10) : key;
       const isLast = index === length - 1;
       fn(key, leftKey, moveDestinations[leftKey], isLast);
     }