Use real Outlook ContentId Attribute to resolve CID Attachments #19
Conversation
| if (!tryAddCid(cidMap, html, fileAttachment, fileAttachment.getFilename())) { | ||
| tryAddCid(cidMap, html, fileAttachment, fileAttachment.getLongFilename()); | ||
| } | ||
| tryAddCid(cidMap, html, fileAttachment, fileAttachment.getContentId()); |
There was a problem hiding this comment.
You removed the failover for using alternative cid's in favor of Outlook native 3712 attribute. Is that guaranteed to be always present?
There was a problem hiding this comment.
To be honest I don't know, I just assumed it does. We can also keep the old failovers too, just to be sure. In my testing 3712 was always there
There was a problem hiding this comment.
Yeah it's better to keep the fallback just in case. If you could please amend it I'll merge and release.
|
Can't release 1.5.0 right now as OSS Sonatype is having network issues again. |
|
Thanks for your work and the smooth and simple process of merging changes! Can you update me once you have successfully published it to the OSS Sonatype? |
|
Released in 1.5.0 |
2 participants
Outlook saves the CID in MSG Files using Attribute 3712. This merge request allows the usage of this attribute for the ContentId