Skip to content

Commit 8abc8e0

Browse files
authored
fix(concatjs): devserver not passing through tags to all targets (#2646)
If a devserver target is currently testonly and marked with the `manual` tag (e.g. if used for e2e testing), then the `manual` tag is not passed to all targets exposed by the ConcatJS devserver macro. i.e. the manifest alias is exposed and results in the manifest to be built -> which inherently means that the actual devserver target is built even though it has the `manual` tag.
1 parent 7cf7d73 commit 8abc8e0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

packages/concatjs/devserver/concatjs_devserver.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ def concatjs_devserver_macro(name, args = [], visibility = None, tags = [], test
235235
native.alias(
236236
name = "%s.MF" % name,
237237
actual = "%s_launcher.MF" % name,
238+
tags = tags,
238239
visibility = visibility,
239240
)
240241

0 commit comments

Comments
 (0)