Skip to content

invalid user-provided repo name crash #2828

Closed
@baxelrod-bdai

Description

@baxelrod-bdai

🐞 bug report

Affected Rule

pip.parse

Is this a regression?

maybe? I get different errors in 1.3.0. but i think this worked in previous versions.

Description

When i specify a repository in my requirements.in file, i get a "invalid user-provided repo name" crash.

🔬 Minimal Reproduction

requirements.in has this:

efficientvit @ git+https://github.com/mit-han-lab/efficientvit.git@4cc0a75fb5225f2986fa5733f5bfe7c8b9ad4813

requirements.lock has stuff like:

efficientvit @ git+https://github.com/mit-han-lab/efficientvit.git@4cc0a75fb5225f2986fa5733f5bfe7c8b9ad4813
    # via -r requirements.in
tinyneuralnetwork @ git+https://github.com/alibaba/TinyNeuralNetwork.git@c9d0ac571086212b4a62d2bacf6bfe12d92556e1
    # via efficientvit

🔥 Exception or Error


ERROR: /home/baxelrod/.cache/bazel/_bazel_baxelrod/223f490fa0c2f2ec38707ddac3dd6272/external/rules_python+/python/private/pypi/extension.bzl:617:20: Traceback (most recent call last):
	File "/home/baxelrod/.cache/bazel/_bazel_baxelrod/223f490fa0c2f2ec38707ddac3dd6272/external/rules_python+/python/private/pypi/extension.bzl", line 617, column 20, in _pip_impl
		whl_library(name = name, **args)
Error in repository_rule: invalid user-provided repo name 'pip_u2204_310__TinyNeuralNetwork_git@c9d0ac571086212b4a62d2bacf6bfe12d92556e1': valid names may contain only A-Z, a-z, 0-9, '-', '_', '.', and must start with a letter
ERROR: error evaluating module extension @@rules_python+//python/extensions:pip.bzl%pip

🌍 Your Environment

Operating System:

  
linux x86_64
  

Output of bazel version:

  
8.1.1
  

Rules_python version:

  
1.4.0-rc2
  

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions