Skip to content

Feature/clients 1063 equals implementations #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2017
Merged

Feature/clients 1063 equals implementations #696

merged 4 commits into from
Feb 9, 2017

Conversation

christopherfrieler
Copy link
Contributor

@christopherfrieler christopherfrieler commented Jan 16, 2017 •
edited by Basho-JIRA
Loading

Added equals() and hashCode() to

  • FetchBucketProperties
  • StoreBucketProperties
  • YokozunaIndex
  • StoreIndex

Related Issue

CLIENTS-1063 (#695)

Motivation and Context

I need the implementations of equals() for mocking in the unit-tests of my client-code.

How Has This Been Tested?

Added brief unit-tests. Local build passes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Javadoc comments for any new public classes, interfaces, etc.
  • A basho_docs PR for new or changed features (basho/basho_docs#???)

@alexmoore alexmoore merged commit e5a4498 into basho:develop Feb 9, 2017
@alexmoore
Copy link
Contributor

Thanks for the changes!

@christopherfrieler christopherfrieler mentioned this pull request Feb 10, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christopherfrieler @alexmoore