Merge pull request microsoft#25416 from Microsoft/tscDiagnostics

Fix typo to fix logging when built with --watch --diagnostics

Author: sheetalkamat

src/compiler/watch.ts

@@ -490,7 +490,7 @@ namespace ts {
 
         const trace = host.trace && ((s: string) => { host.trace!(s + newLine); });
         const watchLogLevel = trace ? compilerOptions.extendedDiagnostics ? WatchLogLevel.Verbose :
-            compilerOptions.diagnostis ? WatchLogLevel.TriggerOnly : WatchLogLevel.None : WatchLogLevel.None;
+            compilerOptions.diagnostics ? WatchLogLevel.TriggerOnly : WatchLogLevel.None : WatchLogLevel.None;
         const writeLog: (s: string) => void = watchLogLevel !== WatchLogLevel.None ? trace! : noop; // TODO: GH#18217
         const { watchFile, watchFilePath, watchDirectory } = getWatchFactory<string>(watchLogLevel, writeLog);
 

src/testRunner/unittests/tscWatchMode.ts

@@ -2313,38 +2313,45 @@ declare module "fs" {
     });
 
     describe("tsc-watch console clearing", () => {
+        const currentDirectoryLog = "Current directory: / CaseSensitiveFileNames: false\n";
+        const fileWatcherAddedLog = [
+            "FileWatcher:: Added:: WatchInfo: f.ts 250 Source file\n",
+            "FileWatcher:: Added:: WatchInfo: /a/lib/lib.d.ts 250 Source file\n"
+        ];
+
+        function getProgramSynchronizingLog(options: CompilerOptions) {
+            return [
+                "Synchronizing program\n",
+                "CreatingProgramWith::\n",
+                "  roots: [\"f.ts\"]\n",
+                `  options: ${JSON.stringify(options)}\n`
+            ];
+        }
+
         function checkConsoleClearing(options: CompilerOptions = {}) {
             const file = {
                 path: "f.ts",
                 content: ""
             };
             const files = [file, libFile];
             const disableConsoleClear = options.diagnostics || options.extendedDiagnostics || options.preserveWatchOutput;
+            const hasLog = options.extendedDiagnostics || options.diagnostics;
             const host = createWatchedSystem(files);
             createWatchOfFilesAndCompilerOptions([file.path], host, options);
-            checkOutputErrorsInitial(host, emptyArray, disableConsoleClear, options.extendedDiagnostics ? [
-                "Current directory: / CaseSensitiveFileNames: false\n",
-                "Synchronizing program\n",
-                "CreatingProgramWith::\n",
-                "  roots: [\"f.ts\"]\n",
-                "  options: {\"extendedDiagnostics\":true}\n",
-                "FileWatcher:: Added:: WatchInfo: f.ts 250 Source file\n",
-                "FileWatcher:: Added:: WatchInfo: /a/lib/lib.d.ts 250 Source file\n"
+            checkOutputErrorsInitial(host, emptyArray, disableConsoleClear, hasLog ? [
+                currentDirectoryLog,
+                ...getProgramSynchronizingLog(options),
+                ...(options.extendedDiagnostics ? fileWatcherAddedLog : emptyArray)
             ] : undefined);
 
             file.content = "//";
             host.reloadFS(files);
             host.runQueuedTimeoutCallbacks();
-            checkOutputErrorsIncremental(host, emptyArray, disableConsoleClear, options.extendedDiagnostics ? [
+            checkOutputErrorsIncremental(host, emptyArray, disableConsoleClear, hasLog ? [
                 "FileWatcher:: Triggered with /f.ts1:: WatchInfo: f.ts 250 Source file\n",
                 "Scheduling update\n",
                 "Elapsed:: 0ms FileWatcher:: Triggered with /f.ts1:: WatchInfo: f.ts 250 Source file\n"
-            ] : undefined, options.extendedDiagnostics ? [
-                "Synchronizing program\n",
-                "CreatingProgramWith::\n",
-                "  roots: [\"f.ts\"]\n",
-                "  options: {\"extendedDiagnostics\":true}\n"
-            ] : undefined);
+            ] : undefined, hasLog ? getProgramSynchronizingLog(options) : undefined);
         }
 
         it("without --diagnostics or --extendedDiagnostics", () => {