Skip to content

Conversation

MattTunny
Copy link
Contributor

Issue #, if available:
no cloudwatch events or teams example
Description of changes:
added example for cloudwatch event to MS teams with sample events

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian keetonian changed the base branch from master to develop August 1, 2018 21:56
@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #530 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #530   +/-   ##
========================================
  Coverage    94.76%   94.76%           
========================================
  Files           71       71           
  Lines         3474     3474           
  Branches       678      678           
========================================
  Hits          3292     3292           
  Misses          93       93           
  Partials        89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29d13d...ffaf39b. Read the comment docs.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MattTunny thank you for the contribution! Sorry it took us so long to get this reviewed!

@keetonian keetonian merged commit 45f6745 into aws:develop Sep 5, 2019
@praneetap praneetap mentioned this pull request Sep 19, 2019
@ilyash
Copy link

ilyash commented Jun 27, 2020

Semantics ignored leading to poor code quality.

  • Function called get_security_group should not send Teams message.
  • Function called lookup_security_group should not send Teams message.
  • Group ID should not be stored in a variable named cidr_address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants