fix: remove OIDC auth from Http Api #1491

keetonian · 2020-03-04T20:58:53Z

Issue #, if available:
N/A

Description of changes:
OIDC and OAuth2 are the same authorization on the backend and the configuration for both is practically the same. This was causing some confusion for customers (and for us), so we decided to remove OIDC and only support the OAuth2 strategy for GA for Http Apis.

Description of how you validated changes:
Local and cloud testing

Checklist:

Write/update tests
make pr passes
Update documentation
Verify transformed template deploys and application functions as expected
Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

samtranslator/model/apigatewayv2.py

codecov-io · 2020-03-05T00:33:58Z

Codecov Report

Merging #1491 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1491      +/-   ##
===========================================
+ Coverage     94.1%   94.12%   +0.02%     
===========================================
  Files           78       78              
  Lines         4900     4921      +21     
  Branches       988      989       +1     
===========================================
+ Hits          4611     4632      +21     
  Misses         134      134              
  Partials       155      155

Impacted Files	Coverage Δ
samtranslator/model/api/http_api_generator.py	`92.27% <ø> (+0.06%)`	⬆️
samtranslator/model/apigatewayv2.py	`93.93% <100%> (-0.8%)`	⬇️
samtranslator/model/eventsources/push.py	`90.78% <0%> (ø)`	⬆️
...translator/plugins/api/implicit_rest_api_plugin.py	`100% <0%> (ø)`	⬆️
samtranslator/model/sam_resources.py	`94.29% <0%> (ø)`	⬆️
samtranslator/plugins/globals/globals.py	`99.05% <0%> (ø)`	⬆️
samtranslator/plugins/api/implicit_api_plugin.py	`98.24% <0%> (+0.01%)`	⬆️
...translator/plugins/api/implicit_http_api_plugin.py	`97.43% <0%> (+0.94%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef92c3f...4dbc15a. Read the comment docs.

alexw91 · 2020-03-05T00:34:06Z

Codecov Report

Merging #1491 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1491      +/-   ##
===========================================
+ Coverage    94.10%   94.12%   +0.02%     
===========================================
  Files           78       78              
  Lines         4900     4921      +21     
  Branches       988      989       +1     
===========================================
+ Hits          4611     4632      +21     
  Misses         134      134              
  Partials       155      155

Impacted Files	Coverage Δ
samtranslator/model/sam_resources.py	`94.29% <0.00%> (ø)`
samtranslator/model/eventsources/push.py	`90.78% <0.00%> (ø)`
samtranslator/plugins/globals/globals.py	`99.05% <0.00%> (ø)`
...translator/plugins/api/implicit_rest_api_plugin.py	`100.00% <0.00%> (ø)`
samtranslator/plugins/api/implicit_api_plugin.py	`98.24% <0.00%> (+0.01%)`	⬆️
samtranslator/model/api/http_api_generator.py	`92.27% <0.00%> (+0.06%)`	⬆️
samtranslator/model/apigatewayv2.py	`93.93% <0.00%> (-0.80%)`	⬇️
...translator/plugins/api/implicit_http_api_plugin.py	`97.43% <0.00%> (+0.94%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef92c3f...4dbc15a. Read the comment docs.

codecov-io · 2020-03-05T00:34:09Z

Codecov Report

Merging #1491 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1491      +/-   ##
===========================================
+ Coverage     94.1%   94.12%   +0.02%     
===========================================
  Files           78       78              
  Lines         4900     4921      +21     
  Branches       988      989       +1     
===========================================
+ Hits          4611     4632      +21     
  Misses         134      134              
  Partials       155      155

Impacted Files	Coverage Δ
samtranslator/model/api/http_api_generator.py	`92.27% <ø> (+0.06%)`	⬆️
samtranslator/model/apigatewayv2.py	`93.93% <100%> (-0.8%)`	⬇️
samtranslator/model/eventsources/push.py	`90.78% <0%> (ø)`	⬆️
...translator/plugins/api/implicit_rest_api_plugin.py	`100% <0%> (ø)`	⬆️
samtranslator/model/sam_resources.py	`94.29% <0%> (ø)`	⬆️
samtranslator/plugins/globals/globals.py	`99.05% <0%> (ø)`	⬆️
samtranslator/plugins/api/implicit_api_plugin.py	`98.24% <0%> (+0.01%)`	⬆️
...translator/plugins/api/implicit_http_api_plugin.py	`97.43% <0%> (+0.94%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef92c3f...4dbc15a. Read the comment docs.

praneetap

I think, instead of breaking our customers with a invalid property error, we should try to put an error message that says this is no longer supported.

keetonian · 2020-03-05T21:06:34Z

Added an explicit error in latest commit.

alexw91 · 2020-03-05T21:43:42Z

Codecov Report

Merging #1491 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1491      +/-   ##
===========================================
+ Coverage    94.10%   94.13%   +0.02%     
===========================================
  Files           78       78              
  Lines         4900     4925      +25     
  Branches       988      990       +2     
===========================================
+ Hits          4611     4636      +25     
  Misses         134      134              
  Partials       155      155

Impacted Files	Coverage Δ
samtranslator/model/apigatewayv2.py	`93.93% <0.00%> (-0.80%)`	⬇️
samtranslator/model/sam_resources.py	`94.29% <0.00%> (ø)`
samtranslator/model/eventsources/push.py	`90.78% <0.00%> (ø)`
samtranslator/plugins/globals/globals.py	`99.05% <0.00%> (ø)`
...translator/plugins/api/implicit_rest_api_plugin.py	`100.00% <0.00%> (ø)`
samtranslator/plugins/api/implicit_api_plugin.py	`98.24% <0.00%> (+0.01%)`	⬆️
samtranslator/model/api/http_api_generator.py	`92.40% <0.00%> (+0.18%)`	⬆️
...translator/plugins/api/implicit_http_api_plugin.py	`97.43% <0.00%> (+0.94%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef92c3f...ea60b27. Read the comment docs.

codecov-io · 2020-03-05T21:43:46Z

Codecov Report

Merging #1491 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1491      +/-   ##
===========================================
+ Coverage     94.1%   94.13%   +0.02%     
===========================================
  Files           78       78              
  Lines         4900     4925      +25     
  Branches       988      990       +2     
===========================================
+ Hits          4611     4636      +25     
  Misses         134      134              
  Partials       155      155

Impacted Files	Coverage Δ
samtranslator/model/apigatewayv2.py	`93.93% <100%> (-0.8%)`	⬇️
samtranslator/model/api/http_api_generator.py	`92.4% <100%> (+0.18%)`	⬆️
samtranslator/model/eventsources/push.py	`90.78% <0%> (ø)`	⬆️
...translator/plugins/api/implicit_rest_api_plugin.py	`100% <0%> (ø)`	⬆️
samtranslator/model/sam_resources.py	`94.29% <0%> (ø)`	⬆️
samtranslator/plugins/globals/globals.py	`99.05% <0%> (ø)`	⬆️
samtranslator/plugins/api/implicit_api_plugin.py	`98.24% <0%> (+0.01%)`	⬆️
...translator/plugins/api/implicit_http_api_plugin.py	`97.43% <0%> (+0.94%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef92c3f...ea60b27. Read the comment docs.

remove oidc auth (redundant)

4dbc15a

ShreyaGangishetty reviewed Mar 5, 2020

View reviewed changes

samtranslator/model/apigatewayv2.py Show resolved Hide resolved

ShreyaGangishetty approved these changes Mar 5, 2020

View reviewed changes

praneetap reviewed Mar 5, 2020

View reviewed changes

Add explicit error if OpenIdConnectUrl is used

ea60b27

praneetap approved these changes Mar 5, 2020

View reviewed changes

praneetap merged commit aba498f into aws:develop Mar 5, 2020

ShreyaGangishetty mentioned this pull request Mar 6, 2020

Release tracker for SAM v1.22.0 release #1486

Closed

keetonian deleted the consolidate-auth branch March 11, 2020 18:57

SampathDilhan mentioned this pull request Dec 2, 2022

HttpApi document is not up to date. awsdocs/aws-sam-developer-guide#163

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: remove OIDC auth from Http Api #1491

fix: remove OIDC auth from Http Api #1491

Uh oh!

keetonian commented Mar 4, 2020 •

edited

Loading

Uh oh!

Uh oh!

codecov-io commented Mar 5, 2020

Uh oh!

alexw91 commented Mar 5, 2020

Uh oh!

codecov-io commented Mar 5, 2020

Uh oh!

praneetap left a comment

Uh oh!

keetonian commented Mar 5, 2020

Uh oh!

alexw91 commented Mar 5, 2020 •

edited

Loading

Uh oh!

codecov-io commented Mar 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: remove OIDC auth from Http Api #1491

fix: remove OIDC auth from Http Api #1491

Uh oh!

Conversation

keetonian commented Mar 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Mar 5, 2020

Codecov Report

Uh oh!

alexw91 commented Mar 5, 2020

Codecov Report

Uh oh!

codecov-io commented Mar 5, 2020

Codecov Report

Uh oh!

praneetap left a comment

Choose a reason for hiding this comment

Uh oh!

keetonian commented Mar 5, 2020

Uh oh!

alexw91 commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov-io commented Mar 5, 2020

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

keetonian commented Mar 4, 2020 •

edited

Loading

alexw91 commented Mar 5, 2020 •

edited

Loading