Skip to content

Conversation

keetonian
Copy link
Contributor

@keetonian keetonian commented Feb 13, 2020

Issue #, if available:
#1317

Description of changes:
Allow setting TimeoutInMillis on HttpApi events.

Description of how you validated changes:
make pr

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian
Copy link
Contributor Author

Will deploy a template and verify that this sets the timeout as expected.

@keetonian keetonian requested a review from jlhood February 13, 2020 01:45
@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #1450 into develop will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1450      +/-   ##
===========================================
- Coverage    94.37%   94.36%   -0.02%     
===========================================
  Files           78       78              
  Lines         4678     4685       +7     
  Branches       934      937       +3     
===========================================
+ Hits          4415     4421       +6     
  Misses         121      121              
- Partials       142      143       +1
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 90.75% <100%> (+0.03%) ⬆️
samtranslator/open_api/open_api.py 93.51% <80%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8121fcc...eed3214. Read the comment docs.

@keetonian
Copy link
Contributor Author

Template verified.

@keetonian keetonian changed the title Add timeoutInMillis to HttpApi events feat: add timeoutInMillis to HttpApi events Feb 13, 2020
@keetonian keetonian changed the title feat: add timeoutInMillis to HttpApi events feat: add TimeoutInMillis to HttpApi events Feb 13, 2020
@alexw91
Copy link

alexw91 commented Feb 14, 2020

Codecov Report

Merging #1450 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1450      +/-   ##
===========================================
- Coverage    94.37%   94.36%   -0.02%     
===========================================
  Files           78       78              
  Lines         4678     4685       +7     
  Branches       934      937       +3     
===========================================
+ Hits          4415     4421       +6     
  Misses         121      121              
- Partials       142      143       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8121fcc...2b19aa1. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1450 into develop will decrease coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1450      +/-   ##
===========================================
- Coverage    94.37%   94.36%   -0.02%     
===========================================
  Files           78       78              
  Lines         4678     4685       +7     
  Branches       934      937       +3     
===========================================
+ Hits          4415     4421       +6     
  Misses         121      121              
- Partials       142      143       +1
Impacted Files Coverage Δ
samtranslator/model/eventsources/push.py 90.75% <100%> (+0.03%) ⬆️
samtranslator/open_api/open_api.py 93.51% <80%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8121fcc...2b19aa1. Read the comment docs.

@jlhood jlhood merged commit ac5b064 into aws:develop Feb 14, 2020
@keetonian keetonian deleted the timeout-millis branch March 11, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants