-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: add TimeoutInMillis to HttpApi events #1450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Will deploy a template and verify that this sets the timeout as expected. |
Codecov Report
@@ Coverage Diff @@
## develop #1450 +/- ##
===========================================
- Coverage 94.37% 94.36% -0.02%
===========================================
Files 78 78
Lines 4678 4685 +7
Branches 934 937 +3
===========================================
+ Hits 4415 4421 +6
Misses 121 121
- Partials 142 143 +1
Continue to review full report at Codecov.
|
Template verified. |
Codecov Report
@@ Coverage Diff @@
## develop #1450 +/- ##
===========================================
- Coverage 94.37% 94.36% -0.02%
===========================================
Files 78 78
Lines 4678 4685 +7
Branches 934 937 +3
===========================================
+ Hits 4415 4421 +6
Misses 121 121
- Partials 142 143 +1 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #1450 +/- ##
===========================================
- Coverage 94.37% 94.36% -0.02%
===========================================
Files 78 78
Lines 4678 4685 +7
Branches 934 937 +3
===========================================
+ Hits 4415 4421 +6
Misses 121 121
- Partials 142 143 +1
Continue to review full report at Codecov.
|
Issue #, if available:
#1317
Description of changes:
Allow setting
TimeoutInMillis
on HttpApi events.Description of how you validated changes:
make pr
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.