-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix: use isinstance check instead of type #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Closed & reopened PR to kick off new travis run. |
Codecov Report
@@ Coverage Diff @@
## develop #1411 +/- ##
===========================================
- Coverage 94.42% 94.42% -0.01%
===========================================
Files 78 78
Lines 4664 4663 -1
Branches 930 930
===========================================
- Hits 4404 4403 -1
Misses 121 121
Partials 139 139
Continue to review full report at Codecov.
|
@kddejong thanks for bringing this up. I will dig into this. Edit: it looks like this PR fixes the issue you reference. We will see if we can get this in soon. |
Thanks @keetonian and @shwetaskatdare |
fix: use isinstance check instead of type (#1411)
Issue #, if available: #1410
Note, had to run
make black
to correct formatting errors elsewhere in the project in order formake pr
to pass.Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.