Skip to content

Conversation

jlhood
Copy link
Contributor

@jlhood jlhood commented Jan 23, 2020

Issue #, if available: #1410

Note, had to run make black to correct formatting errors elsewhere in the project in order for make pr to pass.

Checklist:

  • [n/a] Write/update tests
  • [ x ] make pr passes
  • [n/a] Update documentation
  • [n/a] Verify transformed template deploys and application functions as expected
  • [n/a] Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian
Copy link
Contributor

Closed & reopened PR to kick off new travis run.

@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

Merging #1411 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1411      +/-   ##
===========================================
- Coverage    94.42%   94.42%   -0.01%     
===========================================
  Files           78       78              
  Lines         4664     4663       -1     
  Branches       930      930              
===========================================
- Hits          4404     4403       -1     
  Misses         121      121              
  Partials       139      139
Impacted Files Coverage Δ
samtranslator/translator/translator.py 98.38% <100%> (-0.02%) ⬇️
samtranslator/translator/logical_id_generator.py 90.9% <100%> (ø) ⬆️
samtranslator/model/sam_resources.py 94.06% <100%> (ø) ⬆️
samtranslator/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5f016...7a7adb3. Read the comment docs.

@kddejong
Copy link
Contributor

@keetonian
Copy link
Contributor

keetonian commented Feb 13, 2020

@kddejong thanks for bringing this up. I will dig into this.

Edit: it looks like this PR fixes the issue you reference. We will see if we can get this in soon.

@kddejong
Copy link
Contributor

Thanks @keetonian and @shwetaskatdare

@keetonian keetonian merged commit 8121fcc into aws:develop Feb 13, 2020
keetonian pushed a commit to keetonian/serverless-application-model that referenced this pull request Feb 13, 2020
keetonian added a commit that referenced this pull request Feb 13, 2020
fix: use isinstance check instead of type (#1411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants