Skip to content

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Nov 21, 2019

#945

Thank you for the ping @jpangburn

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #1256 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
+ Coverage   94.43%   94.49%   +0.05%     
==========================================
  Files          71       71              
  Lines        3630     3669      +39     
  Branches      717      717              
==========================================
+ Hits         3428     3467      +39     
  Misses        103      103              
  Partials       99       99
Impacted Files Coverage Δ
samtranslator/model/naming.py 100% <0%> (ø) ⬆️
...amtranslator/policy_template_processor/template.py 100% <0%> (ø) ⬆️
...mtranslator/policy_template_processor/processor.py 100% <0%> (ø) ⬆️
...nslator/model/preferences/deployment_preference.py 100% <0%> (ø) ⬆️
samtranslator/sdk/resource.py 100% <0%> (ø) ⬆️
samtranslator/model/exceptions.py 100% <0%> (ø) ⬆️
samtranslator/region_configuration.py 100% <0%> (ø) ⬆️
samtranslator/intrinsics/actions.py 98.71% <0%> (ø) ⬆️
samtranslator/plugins/globals/globals.py 99.05% <0%> (+0.02%) ⬆️
samtranslator/model/__init__.py 98.14% <0%> (+0.03%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 818b4ef...4a219a4. Read the comment docs.

@ShreyaGangishetty ShreyaGangishetty self-assigned this Nov 22, 2019
Signed-off-by: Gábor Lipták <[email protected]>
@gliptak
Copy link
Contributor Author

gliptak commented Dec 4, 2019

@ShreyaGangishetty the PR is green

Copy link

@ShreyaGangishetty ShreyaGangishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gliptak Thank you for contributing this!
This PR looks good to me

@keetonian keetonian changed the base branch from master to develop December 5, 2019 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants