Skip to content

Conversation

keetonian
Copy link
Contributor

@keetonian keetonian commented Oct 27, 2019

Issue #, if available:
#1038

Description of changes:
Fixes an uncaught error if the RestApiId property contains a dictionary (like an import value statement). SAM does not yet support referencing an Api outside of the current template.

Description of how you validated changes:
Tests written, updated, and pass
Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Oct 27, 2019

Codecov Report

Merging #1224 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1224      +/-   ##
===========================================
+ Coverage    94.43%   94.43%   +<.01%     
===========================================
  Files           72       72              
  Lines         3736     3738       +2     
  Branches       739      740       +1     
===========================================
+ Hits          3528     3530       +2     
  Misses         105      105              
  Partials       103      103
Impacted Files Coverage Δ
samtranslator/plugins/api/implicit_api_plugin.py 98.61% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc8f79...97b405f. Read the comment docs.

@keetonian keetonian changed the title Throw better error for improper api reference fix: throw better error for improper api reference Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants