Skip to content

Conversation

Russ-K
Copy link

@Russ-K Russ-K commented Oct 15, 2019

Issue #, if available:
#1187

Description of changes:
Added a policy for EventBridge putEvents.
This supports putting events for all event buses at this time.

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #1203 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1203   +/-   ##
========================================
  Coverage    94.33%   94.33%           
========================================
  Files           72       72           
  Lines         3725     3725           
  Branches       733      733           
========================================
  Hits          3514     3514           
  Misses         107      107           
  Partials       104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ec0b7...3466f42. Read the comment docs.

@Russ-K Russ-K marked this pull request as ready for review October 15, 2019 11:50
@jlhood
Copy link
Contributor

jlhood commented Oct 15, 2019

Actually, after discussing internally, we're going to put this policy template on hold in case the EventBridge team adds support for per-event bus permissions on PutEvents. See #1187 (comment). Sorry for the back and forth on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants