-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Add support for TriggerConfigurations in DeploymentConfiguration #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for TriggerConfigurations in DeploymentConfiguration #1195
Conversation
Update tests to cover new code
Documentation and example update
Codecov Report
@@ Coverage Diff @@
## develop #1195 +/- ##
===========================================
+ Coverage 94.33% 94.43% +0.09%
===========================================
Files 72 72
Lines 3725 3736 +11
Branches 733 739 +6
===========================================
+ Hits 3514 3528 +14
+ Misses 107 105 -2
+ Partials 104 103 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cakepietoast Thank you for contributing this feature!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great feature! Have some minor doc comments, but the functional code looks good.
Improve documentation reference for trigger config. Co-Authored-By: James Hood <[email protected]>
Remove erroneous comment in documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates look good!
Issue #, if available: #955
Description of changes: Add support for trigger configurations on deployment preference resources.
Description of how you validated changes: Unit tests, test translate & deploy with a simple template making use of the new TriggerConfig parameter in DeploymentConfig.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.