Skip to content

Conversation

to-mc
Copy link
Contributor

@to-mc to-mc commented Oct 12, 2019

Issue #, if available: #955

Description of changes: Add support for trigger configurations on deployment preference resources.

Description of how you validated changes: Unit tests, test translate & deploy with a simple template making use of the new TriggerConfig parameter in DeploymentConfig.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Oct 12, 2019

Codecov Report

Merging #1195 into develop will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1195      +/-   ##
===========================================
+ Coverage    94.33%   94.43%   +0.09%     
===========================================
  Files           72       72              
  Lines         3725     3736      +11     
  Branches       733      739       +6     
===========================================
+ Hits          3514     3528      +14     
+ Misses         107      105       -2     
+ Partials       104      103       -1
Impacted Files Coverage Δ
samtranslator/model/codedeploy.py 100% <ø> (ø) ⬆️
...nslator/model/preferences/deployment_preference.py 100% <100%> (ø) ⬆️
...el/preferences/deployment_preference_collection.py 91.35% <100%> (+0.21%) ⬆️
samtranslator/sdk/parameter.py 100% <0%> (ø) ⬆️
samtranslator/model/sam_resources.py 95.61% <0%> (+0.01%) ⬆️
samtranslator/model/eventsources/push.py 89.81% <0%> (+0.28%) ⬆️
samtranslator/swagger/swagger.py 92.57% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f2a34...61d112a. Read the comment docs.

Copy link

@ShreyaGangishetty ShreyaGangishetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cakepietoast Thank you for contributing this feature!

@ShreyaGangishetty ShreyaGangishetty removed their assignment Oct 24, 2019
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature! Have some minor doc comments, but the functional code looks good.

to-mc and others added 2 commits October 25, 2019 09:18
Improve documentation reference for trigger config.

Co-Authored-By: James Hood <[email protected]>
Remove erroneous comment in documentation
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants