-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Custom domains route53 support #1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,261
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1165 +/- ##
===========================================
- Coverage 94.47% 94.33% -0.15%
===========================================
Files 71 72 +1
Lines 3677 3724 +47
Branches 726 733 +7
===========================================
+ Hits 3474 3513 +39
- Misses 103 107 +4
- Partials 100 104 +4
Continue to review full report at Codecov.
|
cf30f37
to
ddff359
Compare
keetonian
reviewed
Oct 3, 2019
praneetap
commented
Oct 3, 2019
keetonian
approved these changes
Oct 3, 2019
ShreyaGangishetty
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1128 #1129, #783
Description of changes:
Adding Route53 resource generation for custom domains feature.
Description of how you validated changes:
unit tests only so far.
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.