-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add code commit policy templates #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1101 +/- ##
========================================
Coverage 94.72% 94.72%
========================================
Files 70 70
Lines 3430 3430
Branches 675 675
========================================
Hits 3249 3249
Misses 93 93
Partials 88 88 Continue to review full report at Codecov.
|
@ArendAMZN Thanks for the contribution! I haven't dug into all of the specific actions yet, but here's 1 update I need you to do: You made your change against the |
Thanks I fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution! Looks good to me!
] | ||
} | ||
}, | ||
"CodeCommitCrudPolicy": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that permissions and resources are correct.
The only permissions not given here are update/delete permissions on the actual repo, which seems appropriate.
] | ||
} | ||
}, | ||
"CodeCommitReadPolicy": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this policy as well against same documentation.
Issue #, if available:
Description of changes:
Adding policy templates for read and crud for codecommit
Description of how you validated changes:
I ran policy_templates.json through jq to ensure that the syntax is still valid
Here's a diff between the full apis and the ones I used under crud
Here's a diff between the crud apis and the ones I used for read
Checklist:
There aren't tests for config files
make pr
passesdocs/policy_templates.rst
doesn't list all policiesI'm assuming
2016-10-31/policy_templates/all_policy_templates.yaml
shouldn't be updated with policies from new versionsI setup a managed template as follows, and that worked as expected
examples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.