Fix malformed response in example #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The required `isBase64Encoded` field was missing, and `headers` was not correctly formatted. This fixes the "Malformed Lambda proxy response" that caused the method to fail with a 502 status. Some additional information here: https://aws.amazon.com/premiumsupport/knowledge-center/malformed-502-api-gateway/
5 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1096 +/- ##
========================================
Coverage 94.72% 94.72%
========================================
Files 70 70
Lines 3429 3429
Branches 675 675
========================================
Hits 3248 3248
Misses 93 93
Partials 88 88Continue to review full report at Codecov.
|
praneetap
approved these changes
Aug 24, 2019
keetonian
approved these changes
Aug 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required
isBase64Encodedfield was missing, andheaderswas not correctly formatted. This fixes the "Malformed Lambda proxy response" that caused the method to fail with a 502 status.Some additional information here:
https://aws.amazon.com/premiumsupport/knowledge-center/malformed-502-api-gateway/
Description of how you validated changes:
I have first created a
Functionwith the javascript in this example, and got the502. I have then made changes according to the documentation above, and now the correct redirect is returned.Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.