fix: only remove extra stage when OpenApiVersion is set #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1093 +/- ##
===========================================
+ Coverage 94.93% 94.93% +<.01%
===========================================
Files 69 69
Lines 3377 3378 +1
Branches 663 663
===========================================
+ Hits 3206 3207 +1
Misses 89 89
Partials 82 82
Continue to review full report at Codecov.
|
keetonian
requested review from
jlhood and
praneetap
and removed request for
praneetap
keetonian
force-pushed
the
release/v1.14.0-openapi-patch
branch
from
9d59b46 to
a13c2d9
Compare
praneetap
approved these changes
Aug 24, 2019
keetonian
added a commit
to keetonian/serverless-application-model
that referenced
this pull request
Aug 26, 2019
jlhood
added a commit
that referenced
this pull request
Aug 28, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Makes sure the extra stage is only removed when the
OpenApiVersionflag is set.Description of how you validated changes:
Tests updated, also manually verified the fix.
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.