Skip to content

Conversation

keetonian
Copy link
Contributor

Issue #, if available:
#1087

Description of changes:
Allow !Ref and other intrinsics in NotificationARNs property of a Serverless::Application.

Description of how you validated changes:
Tests updated and pass. Deployed a template with desired changes.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #1088 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1088   +/-   ##
========================================
  Coverage    94.93%   94.93%           
========================================
  Files           69       69           
  Lines         3377     3377           
  Branches       663      663           
========================================
  Hits          3206     3206           
  Misses          89       89           
  Partials        82       82
Impacted Files Coverage Δ
samtranslator/model/sam_resources.py 95.49% <ø> (ø) ⬆️
samtranslator/model/cloudformation.py 85.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e371e52...6fd5ddd. Read the comment docs.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for fixing. Just to confirm: this allows any intrinsic, not just Ref, right?

@keetonian
Copy link
Contributor Author

Correct, any intrinsic

@keetonian keetonian changed the title fix: allow references in NotificationARNs property fix: allow intrinsics in NotificationARNs property Aug 16, 2019
@praneetap praneetap self-assigned this Aug 16, 2019
@praneetap praneetap merged commit 1f71077 into aws:develop Aug 19, 2019
@praneetap praneetap mentioned this pull request Sep 19, 2019
@keetonian keetonian deleted the app-notification-arn branch March 11, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants