Request Authorizer, not Token Authorizer #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your SAM Description says this is the "API Gateway with Lambda Token Authorizer" when, I believe, this is a Request Authorizer. Your API resource FunctionPayloadType says "REQUEST" and the link below seems to be the Token Authorizer example. https://github.com/awslabs/serverless-application-model/blob/master/examples/2016-10-31/api_lambda_token_auth/template.yaml
|
Change was made against the wrong base branch. Changed to develop and closed/reopened to kick off another Travis build. |
Codecov Report
@@ Coverage Diff @@
## develop #1068 +/- ##
========================================
Coverage 94.81% 94.81%
========================================
Files 69 69
Lines 3276 3276
Branches 639 639
========================================
Hits 3106 3106
Misses 89 89
Partials 81 81Continue to review full report at Codecov.
|
keetonian
approved these changes
Aug 14, 2019
praneetap
approved these changes
Aug 14, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your SAM Description says this is the "API Gateway with Lambda Token Authorizer" when, I believe, this is a Request Authorizer. Your API resource FunctionPayloadType says "REQUEST" and the link below seems to be the Token Authorizer example.
https://github.com/awslabs/serverless-application-model/blob/master/examples/2016-10-31/api_lambda_token_auth/template.yaml
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.