feat: Cognito event sources #229 #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 6, 2019 12:53
- test script fixed - test added few cases to cognito_userpool_with_event - some make pr fixes - only one permission needs to be created - allow string or array for Trigger
Codecov Report
@@ Coverage Diff @@
## develop #1066 +/- ##
===========================================
- Coverage 94.81% 94.59% -0.22%
===========================================
Files 69 70 +1
Lines 3276 3328 +52
Branches 639 651 +12
===========================================
+ Hits 3106 3148 +42
- Misses 89 93 +4
- Partials 81 87 +6
Continue to review full report at Codecov.
|
keetonian
reviewed
Aug 6, 2019
There was a problem hiding this comment.
All in all, this looks good to me other than the one nit in the docs. I'm going to deploy the updated example to make sure it works as expected and read up on this feature to make sure this is all correct before we merge it in. Thank you for this contribution!
keetonian
approved these changes
Aug 13, 2019
praneetap
approved these changes
Aug 19, 2019
|
Thank you for submitting this feature! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #229, if available:
Description of changes:
Added support for Cognito event sources
It adds only one Permission per Lambda (logical_id de-dupe)
It changes to LambdaConfig property of the Cognito UserPool it refers to
Description of how you validated changes:
Updated the example "examples/2016-10-31/api_cognito_auth"
Transformed and created stack in my account
Checked is PreSignUp trigger correctly refers to the Lambda
Checklist:
make prpassesexamples/2016-10-31other todos:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.