Skip to content

Conversation

singledigit
Copy link
Contributor

@singledigit singledigit commented Aug 1, 2019

Issue #, if available:
#1058

Description of changes:
Updated function event properties to remove 'AwsIotSqlVersion' property. Also removed key: id from Table as it will be auto created. Updated to nodejs10.x

Description of how you validated changes:

sam validate -t template.yaml

Checklist:

  • [na ] Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

… removed Key 'ID' from table as it will be added by default
@codecov-io
Copy link

codecov-io commented Aug 1, 2019

Codecov Report

Merging #1059 into develop will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1059      +/-   ##
===========================================
- Coverage    94.92%   94.81%   -0.12%     
===========================================
  Files           69       69              
  Lines         3250     3276      +26     
  Branches       632      639       +7     
===========================================
+ Hits          3085     3106      +21     
- Misses          87       89       +2     
- Partials        78       81       +3
Impacted Files Coverage Δ
samtranslator/swagger/swagger.py 95.68% <0%> (-1.28%) ⬇️
...lator/plugins/application/serverless_app_plugin.py 83.44% <0%> (ø) ⬆️
samtranslator/model/api/api_generator.py 96.66% <0%> (+0.02%) ⬆️
samtranslator/model/apigateway.py 97.79% <0%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8804733...192f930. Read the comment docs.

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally fine with most of the changes, but I'd prefer to leave the AwsIotSqlVersion property in the example.

@singledigit
Copy link
Contributor Author

Updated and pushed for review

Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate you updating this! One thing to note: the latest released SAM CLI (v0.19.0) still hits a validation error on this template, but it's because of a known issue that will be fixed in the next SAM CLI release. I verified on a development build of SAM CLI that validate succeeds on this template with your changes.

@keetonian keetonian merged commit f280aae into aws:develop Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants