-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix Authorizer: NONE support with AWS_IAM authorizer #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! The Travis build is failing. Once those errors are fixed we will give this a deeper review. |
Ran tests locally and they all passed. Re-running travis. |
Codecov Report
@@ Coverage Diff @@
## develop #1015 +/- ##
========================================
Coverage 94.81% 94.81%
========================================
Files 69 69
Lines 3276 3276
Branches 639 639
========================================
Hits 3106 3106
Misses 89 89
Partials 81 81
Continue to review full report at Codecov.
|
I need this fix folks, just checking in! |
Thank you for the contribution! Could you please add end to end tests (Input/Output) that verifies the fix? You can take a look at this pr for guidance. Please make sure you follow the pr checklist. |
I attempted to add an end to end test, but it appears that it has issues in Python2.7. I don't understand what the issue is exactly. Any direction on this would be helpful. I'll get back to it. |
It appears my output files had issues with Python2.7. I fixed them and now the tests pass. |
Issue #1014
Description of changes:
Change the validation of
method_authorizer
to support the combination ofAWS_IAM
default authorizer andNONE
method authorizer.When using
AWS_IAM
permission, it is only specified in theDefaultAuthorizer
. Reference. This is a special case which leads to theapi_authorizers
being empty and results to not being able to addto a specific function, in order to override the default authorizer and make the function public.
Description of how you validated changes:
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.