Skip to content

Panic when X-Ray header not present #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Panic when X-Ray header not present #91

merged 4 commits into from
Feb 26, 2019

Conversation

sapessi
Copy link
Contributor

@sapessi sapessi commented Feb 26, 2019

Addressing panic when the X-Ray header is not present. This can happen when X-Ray is not available in the region - for example GovCloud.

Issue #, if available: #89

Description of changes:

  • Changed the context objects in the library to use Option<String> for the trace id
  • Changed parsing of header value in the runtime client
  • Added basic unit tests.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

…upport in GovCloud. This addresses issue #89. Also bumped version for patch release.
@sapessi sapessi requested a review from davidbarsky February 26, 2019 22:05
@sapessi sapessi merged commit d739445 into master Feb 26, 2019
@davidbarsky davidbarsky deleted the xray-panic branch February 26, 2019 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants