Skip to content

Remove sync from lambda-http handler #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2021
Merged

Remove sync from lambda-http handler #289

merged 1 commit into from
Feb 14, 2021

Conversation

@bahildebrand
Copy link
Contributor

@bahildebrand bahildebrand commented Feb 13, 2021 •
edited
Loading

Sync was added to the lambda http handler preventing handlers that used
non-sync traits.

Closes #287

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@bahildebrand
Remove sync from lambda-http handler
2276bee 
Sync was added to the lambda http handler preventing handlers that used
non-sync traits.
coltonweaver
coltonweaver approved these changes Feb 13, 2021
View reviewed changes
Copy link
Contributor

@coltonweaver coltonweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bahildebrand bahildebrand merged commit a5f642d into aws:master Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@coltonweaver coltonweaver coltonweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to use third party async libraries due to Sync requirements

2 participants

@bahildebrand @coltonweaver