Skip to content

Optimize simulated read/write #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Optimize simulated read/write #280

wants to merge 5 commits into from

Conversation

coolreader18
Copy link
Contributor

Description of changes:
Split off from #276

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@coolreader18 coolreader18 force-pushed the optimize-simulated-read branch from d494ee2 to 3aaa169 Compare January 26, 2021 18:59
@coltonweaver
Copy link
Contributor

I think what we want to do is replace SimStream in simulated.rs with DuplexStream, and reduce the amount of code here overall.

I'm going to close this PR in favor of that and create an issue for it.

@coltonweaver
Copy link
Contributor

#281

Issue opened here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coolreader18 @coltonweaver