Skip to content

ci: Remove pylint #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2023
Merged

ci: Remove pylint #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
791fcf2
ci: Remove pylint
aahung Feb 1, 2023
e1e38f7
Loose ruff requirement, the risk of new version having more errors be…
aahung Feb 1, 2023
156a310
Tight ruff requirement again
aahung Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
361 changes: 0 additions & 361 deletions .pylintrc
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,9 @@ black-check:
bin/yaml-format.py --check integration --add-test-metadata

lint:
# experimental: use ruff to perform checks before pylint to see
# if it can check issues before pylint
ruff samtranslator bin schema_source
# mypy performs type check
mypy --strict samtranslator bin schema_source
# Linter performs static analysis to catch latent bugs
pylint --rcfile .pylintrc samtranslator schema_source
# cfn-lint to make sure generated CloudFormation makes sense
bin/run_cfn_lint.sh

Expand Down
1 change: 0 additions & 1 deletion requirements/dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ pytest-cov~=2.10.1
pytest-xdist~=2.5
pytest-env~=0.6.2
pytest-rerunfailures~=9.1.1
pylint~=2.15.0
pyyaml~=5.4
ruff==0.0.237 # loose the requirement once it is more stable

Expand Down
2 changes: 0 additions & 2 deletions samtranslator/model/api/api_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ def _construct_stage(
def _construct_api_domain(
self, rest_api: ApiGatewayRestApi, route53_record_set_groups: Any
) -> Tuple[Optional[ApiGatewayDomainName], Optional[List[ApiGatewayBasePathMapping]], Any]:
# pylint: disable=duplicate-code
"""
Constructs and returns the ApiGateway Domain and BasepathMapping
"""
Expand Down Expand Up @@ -585,7 +584,6 @@ def _construct_record_sets_for_domain(
return recordset_list

def _construct_alias_target(self, domain: Dict[str, Any], api_domain_name: str, route53: Any) -> Dict[str, Any]:
# pylint: disable=duplicate-code
alias_target = {}
target_health = route53.get("EvaluateTargetHealth")

Expand Down
Loading