fix(apigw): ValueError is not caught by int() (#2305)

Author: wchengru

samtranslator/model/apigateway.py

@@ -285,7 +285,7 @@ def _is_missing_identity_source(self, identity):
         try:
             ttl_int = int(ttl)
         # this will catch if ttl is None and not convertable to an int
-        except TypeError:
+        except (TypeError, ValueError):
             # previous behavior before trying to read ttl
             return required_properties_missing
 

tests/validator/input/api/error_auth_cognito.yaml

@@ -43,6 +43,10 @@ Resources:
             Identity:
               ReauthorizeEvery: "3"
             UserPoolArn: User.pool.arn
+          CognitoIdentityReauthorizeEveryValueError:
+            Identity:
+              ReauthorizeEvery: NotANumber
+            UserPoolArn: User.pool.arn
           CognitoIdentityReauthorizeEveryTooHigh:
             Identity:
               ReauthorizeEvery: 3601

tests/validator/output/api/error_auth_cognito.json

@@ -9,6 +9,7 @@
   "[Resources.MyApi.Properties.Auth.Authorizers.CognitoIdentityReauthorizeEveryNotInt.Identity.ReauthorizeEvery] '3' is not of type 'integer', 'intrinsic'",
   "[Resources.MyApi.Properties.Auth.Authorizers.CognitoIdentityReauthorizeEveryTooHigh.Identity.ReauthorizeEvery] 3601 is greater than the maximum of 3600",
   "[Resources.MyApi.Properties.Auth.Authorizers.CognitoIdentityReauthorizeEveryTooLow.Identity.ReauthorizeEvery] 0 is less than the minimum of 1",
+  "[Resources.MyApi.Properties.Auth.Authorizers.CognitoIdentityReauthorizeEveryValueError.Identity.ReauthorizeEvery] 'NotANumber' is not of type 'integer', 'intrinsic'",
   "[Resources.MyApi.Properties.Auth.Authorizers.CognitoIdentityValidationExpressionEmpty.Identity.ValidationExpression] Must not be empty",
   "[Resources.MyApi.Properties.Auth.Authorizers.CognitoIdentityValidationExpressionNotString.Identity.ValidationExpression] 3 is not of type 'string'",
   "[Resources.MyApi.Properties.Auth.Authorizers.CognitoUserPoolArnEmpty.UserPoolArn] Must not be empty",