Skip to content

Commit e31e880

Browse files
eugeniosupraneetap
authored andcommitted
feat: adding VPC Access Policy when VpcConfig is present (#1228)
1 parent 26411ce commit e31e880

File tree

4 files changed

+18
-8
lines changed

4 files changed

+18
-8
lines changed

samtranslator/model/sam_resources.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,10 @@ def _construct_role(self, managed_policy_map):
198198
managed_policy_arns = [ArnGenerator.generate_aws_managed_policy_arn('service-role/AWSLambdaBasicExecutionRole')]
199199
if self.Tracing:
200200
managed_policy_arns.append(ArnGenerator.generate_aws_managed_policy_arn('AWSXrayWriteOnlyAccess'))
201+
if self.VpcConfig:
202+
managed_policy_arns.append(
203+
ArnGenerator.generate_aws_managed_policy_arn('service-role/AWSLambdaVPCAccessExecutionRole')
204+
)
201205

202206
function_policies = FunctionPolicies({"Policies": self.Policies},
203207
# No support for policy templates in the "core"

tests/translator/output/aws-cn/globals_for_function.json

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
"Type": "AWS::IAM::Role",
55
"Properties": {
66
"ManagedPolicyArns": [
7-
"arn:aws-cn:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole",
8-
"arn:aws-cn:iam::aws:policy/AWSXrayWriteOnlyAccess"
7+
"arn:aws-cn:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole",
8+
"arn:aws-cn:iam::aws:policy/AWSXrayWriteOnlyAccess",
9+
"arn:aws-cn:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole"
910
],
1011
"Tags": [
1112
{
@@ -105,8 +106,9 @@
105106
"Type": "AWS::IAM::Role",
106107
"Properties": {
107108
"ManagedPolicyArns": [
108-
"arn:aws-cn:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole",
109-
"arn:aws-cn:iam::aws:policy/AWSXrayWriteOnlyAccess"
109+
"arn:aws-cn:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole",
110+
"arn:aws-cn:iam::aws:policy/AWSXrayWriteOnlyAccess",
111+
"arn:aws-cn:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole"
110112
],
111113
"Tags": [
112114
{

tests/translator/output/aws-us-gov/globals_for_function.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
"Properties": {
66
"ManagedPolicyArns": [
77
"arn:aws-us-gov:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole",
8-
"arn:aws-us-gov:iam::aws:policy/AWSXrayWriteOnlyAccess"
8+
"arn:aws-us-gov:iam::aws:policy/AWSXrayWriteOnlyAccess",
9+
"arn:aws-us-gov:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole"
910
],
1011
"PermissionsBoundary": "arn:aws:1234:iam:boundary/OverridePermissionsBoundary",
1112
"Tags": [
@@ -106,7 +107,8 @@
106107
"Properties": {
107108
"ManagedPolicyArns": [
108109
"arn:aws-us-gov:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole",
109-
"arn:aws-us-gov:iam::aws:policy/AWSXrayWriteOnlyAccess"
110+
"arn:aws-us-gov:iam::aws:policy/AWSXrayWriteOnlyAccess",
111+
"arn:aws-us-gov:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole"
110112
],
111113
"PermissionsBoundary": "arn:aws:1234:iam:boundary/CustomerCreatedPermissionsBoundary",
112114
"Tags": [

tests/translator/output/globals_for_function.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
"Properties": {
66
"ManagedPolicyArns": [
77
"arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole",
8-
"arn:aws:iam::aws:policy/AWSXrayWriteOnlyAccess"
8+
"arn:aws:iam::aws:policy/AWSXrayWriteOnlyAccess",
9+
"arn:aws:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole"
910
],
1011
"PermissionsBoundary": "arn:aws:1234:iam:boundary/OverridePermissionsBoundary",
1112
"Tags": [
@@ -106,7 +107,8 @@
106107
"Properties": {
107108
"ManagedPolicyArns": [
108109
"arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole",
109-
"arn:aws:iam::aws:policy/AWSXrayWriteOnlyAccess"
110+
"arn:aws:iam::aws:policy/AWSXrayWriteOnlyAccess",
111+
"arn:aws:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole"
110112
],
111113
"PermissionsBoundary": "arn:aws:1234:iam:boundary/CustomerCreatedPermissionsBoundary",
112114
"Tags": [

0 commit comments

Comments
 (0)