Fix all warnings in tests (#2303)

* Fix all warnings in tests

* Black reformat

Author: hawflau

pytest.ini

@@ -5,4 +5,6 @@ addopts = --cov samtranslator --cov-report term-missing --cov-fail-under 95
 testpaths = tests
 env =
     AWS_DEFAULT_REGION = ap-southeast-1
+markers =
+    slow: marks tests as slow (deselect with '-m "not slow"')
 

requirements/dev.txt

@@ -3,6 +3,7 @@ flake8~=3.8.4
 tox~=3.24
 pytest-cov~=2.10.1
 pytest-xdist~=2.5
+pytest-env~=0.6.2
 pylint>=1.7.2,<2.0
 pyyaml~=5.4
 

samtranslator/intrinsics/actions.py

@@ -370,8 +370,8 @@ def handler_method(full_ref, ref_value):
         """
 
         # RegExp to find pattern "${logicalId.property}" and return the word inside bracket
-        logical_id_regex = "[A-Za-z0-9\.]+|AWS::[A-Z][A-Za-z]*"
-        ref_pattern = re.compile(r"\$\{(" + logical_id_regex + ")\}")
+        logical_id_regex = r"[A-Za-z0-9\.]+|AWS::[A-Z][A-Za-z]*"
+        ref_pattern = re.compile(r"\$\{(" + logical_id_regex + r")\}")
 
         # Find all the pattern, and call the handler to decide how to substitute them.
         # Do the substitution and return the final text

samtranslator/metrics/metrics.py

@@ -125,7 +125,9 @@ def __init__(self, namespace="ServerlessTransform", metrics_publisher=None):
     def __del__(self):
         if len(self.metrics_cache) > 0:
             # attempting to publish if user forgot to call publish in code
-            LOG.warn("There are unpublished metrics. Please make sure you call publish after you record all metrics.")
+            LOG.warning(
+                "There are unpublished metrics. Please make sure you call publish after you record all metrics."
+            )
             self.publish()
 
     def _record_metric(self, name, value, unit, dimensions=None):

samtranslator/model/eventsources/push.py

@@ -831,7 +831,7 @@ def _add_swagger_integration(self, api, function, intrinsics_resolver):
 
                     parameter_name, parameter_value = next(iter(parameter.items()))
 
-                    if not re.match("method\.request\.(querystring|path|header)\.", parameter_name):
+                    if not re.match(r"method\.request\.(querystring|path|header)\.", parameter_name):
                         raise InvalidEventException(
                             self.relative_id,
                             "Invalid value for 'RequestParameters' property. Keys must be in the format "
@@ -855,7 +855,7 @@ def _add_swagger_integration(self, api, function, intrinsics_resolver):
                     parameters.append(settings)
 
                 elif isinstance(parameter, str):
-                    if not re.match("method\.request\.(querystring|path|header)\.", parameter):
+                    if not re.match(r"method\.request\.(querystring|path|header)\.", parameter):
                         raise InvalidEventException(
                             self.relative_id,
                             "Invalid value for 'RequestParameters' property. Keys must be in the format "

samtranslator/open_api/open_api.py

@@ -107,7 +107,7 @@ def get_integration_function_logical_id(self, path_name, method_name):
             arn = uri.get("Fn::Sub", "")
 
         # Extract lambda integration (${LambdaName.Arn}) and split ".Arn" off from it
-        regex = "([A-Za-z0-9]+\.Arn)"
+        regex = r"([A-Za-z0-9]+\.Arn)"
         matches = re.findall(regex, arn)
         # Prevent IndexError when integration URI doesn't contain .Arn (e.g. a Function with
         # AutoPublishAlias translates to AWS::Lambda::Alias, which make_shorthand represents