Skip to content

Commit 56cbed3

Browse files
authored
fix: log a warning on invalid schema validation (#466)
1 parent 8bada14 commit 56cbed3

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

samtranslator/parser/parser.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
from samtranslator.validator.validator import SamTemplateValidator
33
from samtranslator.model import ResourceTypeResolver, sam_resources
44
from samtranslator.plugins import LifeCycleEvents
5+
import logging
56

67
class Parser:
78
def __init__(self):
@@ -25,4 +26,11 @@ def _validate(self, sam_template, parameter_values):
2526
raise InvalidDocumentException(
2627
[InvalidTemplateException("'Resources' section is required")])
2728

28-
SamTemplateValidator.validate(sam_template)
29+
validation_errors = SamTemplateValidator.validate(sam_template)
30+
has_errors = len(validation_errors)
31+
32+
if has_errors:
33+
# NOTE: eventually we will throw on invalid schema
34+
# raise InvalidDocumentException([InvalidTemplateException(validation_errors)])
35+
logging.warning(
36+
"JSON_VALIDATION_WARNING: {0}".format(validation_errors))

0 commit comments

Comments
 (0)