Skip to content

Commit 54a7c51

Browse files
committed
Address code review comments
1 parent f2a2af2 commit 54a7c51

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

samtranslator/plugins/application/serverless_app_plugin.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,8 @@ def on_after_transform_template(self, template):
316316
while (time() - start_time) < self.TEMPLATE_WAIT_TIMEOUT_SECONDS:
317317
temp = self._in_progress_templates
318318
self._in_progress_templates = []
319+
# it's either our first time in this loop or we just slept SLEEP_TIME_SECONDS so we can
320+
# try calling SAR
319321
throttled = False
320322

321323
# Check each resource to make sure it's active

tests/plugins/application/test_serverless_app_plugin.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,6 @@ def __init__(self, app_id="app_id", semver="1.3.5"):
257257

258258

259259
class TestServerlessAppPlugin_on_after_transform_template(TestCase):
260-
def setUp(self):
261-
pass
262-
263260
def test_sar_throttling_doesnt_stop_processing(self):
264261
client = Mock()
265262
client.get_cloud_formation_template = Mock()

0 commit comments

Comments
 (0)