fix: adding support for passing target id to EventBridgeRule (#1747)

Author: c2tarun

samtranslator/model/eventsources/push.py

@@ -150,6 +150,7 @@ class CloudWatchEvent(PushEventSource):
         "Pattern": PropertyType(False, is_type(dict)),
         "Input": PropertyType(False, is_str()),
         "InputPath": PropertyType(False, is_str()),
+        "Target": PropertyType(False, is_type(dict)),
     }
 
     def to_cloudformation(self, **kwargs):
@@ -187,7 +188,8 @@ def _construct_target(self, function):
         :returns: the Target property
         :rtype: dict
         """
-        target = {"Arn": function.get_runtime_attr("arn"), "Id": self.logical_id + "LambdaTarget"}
+        target_id = self.Target["Id"] if self.Target and "Id" in self.Target else self.logical_id + "LambdaTarget"
+        target = {"Arn": function.get_runtime_attr("arn"), "Id": target_id}
         if self.Input is not None:
             target["Input"] = self.Input
 

tests/model/eventsources/test_cloudwatch_event_source.py

@@ -0,0 +1,24 @@
+from mock import Mock, patch
+from unittest import TestCase
+
+from samtranslator.model.eventsources.push import CloudWatchEvent
+from samtranslator.model.lambda_ import LambdaFunction
+
+
+class CloudWatchEventSourceTests(TestCase):
+    def setUp(self):
+        self.logical_id = "EventLogicalId"
+        self.func = LambdaFunction("func")
+
+    def test_target_id_when_not_provided(self):
+        cloudwatch_event_source = CloudWatchEvent(self.logical_id)
+        cfn = cloudwatch_event_source.to_cloudformation(function=self.func)
+        target_id = cfn[0].Targets[0]["Id"]
+        self.assertEqual(target_id, "{}{}".format(self.logical_id, "LambdaTarget"))
+
+    def test_target_id_when_provided(self):
+        cloudwatch_event_source = CloudWatchEvent(self.logical_id)
+        cloudwatch_event_source.Target = {"Id": "MyTargetId"}
+        cfn = cloudwatch_event_source.to_cloudformation(function=self.func)
+        target_id = cfn[0].Targets[0]["Id"]
+        self.assertEqual(target_id, "MyTargetId")